transgui icon indicating copy to clipboard operation
transgui copied to clipboard

Rename Files Exits Rename Mode Early

Open nickv2002 opened this issue 1 year ago • 1 comments

When renaming files, typing certain characters in a given order will cause transgui to exit out of the rename mode and jump the selection to another torrent in the list.

For example, if I start renaming a file and type mam or fa or aaa at the beginning of a torrent I'm trying to rename this will happen. I haven't been able to make sense of the pattern of strings that trigger it but it basically prevents me from renaming anything normally (instead I write the new name elsewhere and copy/paste it in).

I'm using Transition Remote GUI v5.18.7.f on macOS 14.7 but the problem has been around for a while to the best of my memory. I saw the same behavior running the windows version of Transition Remote GUI v5.18.7.f on my Mac using Wine so it's not unique to the macOS build.

Any ideas on the cause or fix? I'm

nickv2002 avatar Sep 26 '24 21:09 nickv2002

Hi, thanks for the report.

I can reproduce this under Linux as well - crazy that something like this has gone unnoticed for all this time.

lighterowl avatar Sep 27 '24 06:09 lighterowl

The cause ended up being TVarGrid.UTF8KeyPress which wasn't skipped when the grid is in "editor mode". Although that function calls the base class implementation which is supposed to return an empty string if it handled the key press itself (presumably by forwarding it to the editor), in my testing this wasn't true and an extra check for EditorMode is needed either way.

Also, old code checked for #0 instead of an empty string.

lighterowl avatar Jan 25 '25 12:01 lighterowl

Thanks! Looking forward to the next release with this fix!

nickv2002 avatar Jan 25 '25 20:01 nickv2002