xskillscore
xskillscore copied to clipboard
incorporate properscoring in this repo
I think we have discussed this before but not sure where.
properscoring is under an Apache license https://github.com/TheClimateCorporation/properscoring/blob/master/LICENSE and is no longer maintained.
We could bring it's functionality into this repo and therefore reduce the imports as well as things such as https://github.com/xarray-contrib/xskillscore/issues/233
basically just copying their code?
basically just copying their code?
Yep and of course give them credit.
This would sit in np_probabilistic.py (#243)
I think this is a good idea for keeping things maintained going forward.
Once we took over, invite this PR https://github.com/TheClimateCorporation/properscoring/issues/7 and raise issue in ps that we forked
code would live in here: https://github.com/xarray-contrib/xskillscore/blob/main/xskillscore/core/np_probabilistic.py
It's been awhile: I'm now maintaining (for lack of a better word) the Climate repo. How can I help?
@billga I'm the original author of properscoring, back when I worked at Climate. Perhaps you could add me as an editor for the repository, and/or let me transfer it to a new GitHub organziation?
Ack, and I'll respond in more detail when I'm near my laptop
I'm glad to make contact @shoyer. I see your contributions all over our source code, it's good to e-meet you. It makes sense to transfer this to a place it can enjoy more attention and community support. If you or @raybellwaves can allow me temporary create-repo access to this org, I can transfer the project (also assuming there isn't already a repo named 'properscoring' here).
There is a specific set of requirements for this org (xarray-contrib) that don't really make sense for properscoring: https://github.com/xarray-contrib/xarray-contrib. Namely, xarray-contrib is supposed to be for xarray "add on" packages, which xskillscore qualifies as, but not properscoring.
My suggestion would be moving properscoring into a separate GitHub org instead.
If that sounds good to you, I just created https://github.com/properscoring and sent @raybellwaves @billga @aaronspring and @dougiesquire invitations with admin permission.
Moved TheClimateCorporation/properscoring to properscoring/properscoring... it looks like it succeeded without error, and the automatic redirect works.
Amazing, thank you @billga !