cupy-xarray icon indicating copy to clipboard operation
cupy-xarray copied to clipboard

Published 20 hours ago • verified publisher icon xarray-contrib

Add CI workflows

Open andersy005 opened this issue 1 year ago • 5 comments

  • [x] Add pre-commit configuration
  • [x] ~~Remove versioneer and use setuptools-scm~~
  • [ ] Add Github workflow for testing infrastructure
  • [x] Rename branch from master -> main

andersy005 avatar Jul 28 '22 22:07 andersy005

Curious could you please share some more context on the preference of setuptools-scm over versioneer?

jakirkham avatar Jul 29 '22 00:07 jakirkham

Curious could you please share some more context on the preference of setuptool-scm over versioneer?

The last time i used it (late 2019), versioneer was no longer actively maintained but it appears its development has resumed and some of the missing features (e.g. https://github.com/python-versioneer/python-versioneer/issues/146) seem to be on the roadmap. So, perhaps this change isn't necessary

andersy005 avatar Jul 29 '22 00:07 andersy005

Recall there being some edge cases with setuptools-scm. In particular sdists would need to be generated and uploaded to PyPI for downstream packagers to make sure they have access to version info when building packages (as GitHub archives wouldn't include this for example).

jakirkham avatar Jul 29 '22 00:07 jakirkham

that particular issue has been fixed in recent versions of setuptools-scm, but still requires additional configuration

keewis avatar Jul 29 '22 08:07 keewis

Versioneer picked up development again and has been good lately. I'm continuing to use it in other projects over setuptools-scm.

jacobtomlinson avatar Jul 29 '22 16:07 jacobtomlinson