⚠️ Nightly upstream-dev CI failed ⚠️

[github-actions[bot]]

Workflow Run URL

Python 3.10 Test Summary

cf_xarray/tests/test_accessor.py::test_add_bounds[time2]: assert 139791139769040 == 139791146878224
 +  where 139791139769040 = id(2)
 +  and   139791146878224 = id(2)
cf_xarray/tests/test_accessor.py::test_add_bounds[lat]: assert 139791140885264 == 139791146878224
 +  where 139791140885264 = id(2)
 +  and   139791146878224 = id(2)
cf_xarray/tests/test_accessor.py::test_add_bounds[time]: assert 139791136441520 == 139791146878224
 +  where 139791136441520 = id(2)
 +  and   139791146878224 = id(2)
cf_xarray/tests/test_accessor.py::test_add_bounds[dims3]: assert 139791137270768 == 139791146878224
 +  where 139791137270768 = id(2)
 +  and   139791146878224 = id(2)
cf_xarray/tests/test_accessor.py::test_bounds_to_vertices: assert 139791139771920 == 139791146878224
 +  where 139791139771920 = id(2)
 +  and   139791146878224 = id(2)
cf_xarray/tests/test_accessor.py::test_add_canonical_attributes[True-units-True]: assert 139791138930256 == 139791146878224
 +  where 139791138930256 = id(2)
 +  and   139791146878224 = id(2)
cf_xarray/tests/test_accessor.py::test_add_canonical_attributes[True-units-False]: assert 139791138833168 == 139791146878224
 +  where 139791138833168 = id(2)
 +  and   139791146878224 = id(2)
cf_xarray/tests/test_accessor.py::test_add_canonical_attributes[True-None-True]: assert 139791137270896 == 139791146878224
 +  where 139791137270896 = id(2)
 +  and   139791146878224 = id(2)
cf_xarray/tests/test_accessor.py::test_add_canonical_attributes[False-None-False]: assert 140370373204112 == 140370391909744
 +  where 140370373204112 = id(2)
 +  and   140370391909744 = id(2)
cf_xarray/tests/test_accessor.py::test_add_canonical_attributes[True-None-False]: assert 139791139778032 == 139791146878224
 +  where 139791139778032 = id(2)
 +  and   139791146878224 = id(2)
cf_xarray/tests/test_accessor.py::test_add_canonical_attributes[False-units-True]: assert 139791136445808 == 139791146878224
 +  where 139791136445808 = id(2)
 +  and   139791146878224 = id(2)
cf_xarray/tests/test_accessor.py::test_add_canonical_attributes[False-units-False]: assert 139791138479856 == 139791146878224
 +  where 139791138479856 = id(2)
 +  and   139791146878224 = id(2)
cf_xarray/tests/test_accessor.py::test_add_canonical_attributes[False-None-True]: assert 139791138915056 == 139791146878224
 +  where 139791138915056 = id(2)
 +  and   139791146878224 = id(2)

[dcherian]

I think the change is to deepcopy of attrs which is indeed deepcopying now, and so we can't use the is comparison anymore. We need to rethink the use of _check_unchanged