bromite-userscripts icon indicating copy to clipboard operation
bromite-userscripts copied to clipboard

Unsure cosmetic filtering is even working

Open chris122380 opened this issue 3 years ago • 2 comments

I am unsure what websites this cosmetic filtering is supposed to be working on. I have followed the directions for installing the plugin. I have also added the extended filter (https://github.com/xarantolus/filtrite/releases/latest/download/bromite-extended.dat). I am still getting white space on many webpages.

Example 1: KSL news (KSL.com) Screenshot_2022-06-19-22-04-41-67_ed7821ed99ee442dec4ede205e7971d6 Screenshot_2022-06-19-22-04-45-87_ed7821ed99ee442dec4ede205e7971d6

Example 2: celebwell.com Screenshot_2022-06-19-22-06-18-78_ed7821ed99ee442dec4ede205e7971d6

Bromite 102.0.5005.96 Oxygen OS 12 (OnePlus 9 Pro)

chris122380 avatar Jun 20 '22 04:06 chris122380

So for the first page there are filters available, but they are more advanced; the script currently doesn't support them:

ksl.com#?#.queue:-abp-has(.sponsored)

Supporting this type of selector would probably be quite some work and have quite a performance impact; I'd prefer to keep the logic simple.

For the second one there just aren't any filters in the lists that I added.

In general the script is really basic, so it tends to only work on pages with rather basic blockable elements (It does remove a lot of full-screen overlays on different pages though, which is nice).

xarantolus avatar Jun 20 '22 04:06 xarantolus

So for the first page there are filters available, but they are more advanced; the script currently doesn't support them:

ksl.com#?#.queue:-abp-has(.sponsored)

Supporting this type of selector would probably be quite some work and have quite a performance impact; I'd prefer to keep the logic simple.

For the second one there just aren't any filters in the lists that I added.

In general the script is really basic, so it tends to only work on pages with rather basic blockable elements (It does remove a lot of full-screen overlays on different pages though, which is nice).

This is why I don't tend to use Bromite. It has to much white space and/or cosmetic issue not seen with other browsers.

chris122380 avatar Jun 20 '22 05:06 chris122380