django-static-sitemaps icon indicating copy to clipboard operation
django-static-sitemaps copied to clipboard

Ping deprecated

Open koutoftimer opened this issue 1 year ago • 4 comments

https://developers.google.com/search/blog/2023/06/sitemaps-lastmod-ping

tasks.GenerateSitemap now throws

HTTP Error 404: Sitemaps ping is deprecated. See https://developers.google.com/search/blog/2023/06/sitemaps-lastmod-ping.

koutoftimer avatar Jan 09 '24 08:01 koutoftimer

Until this gets removed you can set STATICSITEMAPS_PING_GOOGLE to False in your settings.py.

jeffbowen avatar Jan 13 '24 01:01 jeffbowen

I made a pr https://github.com/xaralis/django-static-sitemaps/pull/79

Until this gets removed you can set STATICSITEMAPS_PING_GOOGLE to False in your settings.py.

It wont help at latest Django 5 because there's an import https://github.com/xaralis/django-static-sitemaps/blob/dd4dc66da78bd9f394eb8689eff3c406e3c45499/static_sitemaps/generator.py#L14 of ping_google that doesn't exist anymore at Django.

Akay7 avatar Jan 17 '24 08:01 Akay7

@Akay7 I guess, it is good "first PR": just to wrap that import into if condition and, probably, add some tests.

koutoftimer avatar Jan 17 '24 08:01 koutoftimer

I guess, it is good "first PR": just to wrap that import into if condition

There's no needs to ping google because that endpoint is deprecated on google side. And if there's no endpoint then there's no things to ping even with older version of Django.

and, probably, add some tests.

It's about removing functionality, in this case I should have removed the tests rather than writing them.

Akay7 avatar Jan 17 '24 09:01 Akay7

+1 for @Akay7 fix, is there a maintainer around? @xaralis maybe?

mpasternak avatar Feb 06 '24 07:02 mpasternak

Released as v5.0.0, thanks @Akay7 . Sorry for the delay, tons of other stuff. https://pypi.org/project/django-static-sitemaps/5.0.0/

xaralis avatar Feb 18 '24 09:02 xaralis