vuex-shared-mutations icon indicating copy to clipboard operation
vuex-shared-mutations copied to clipboard

Use BroadcastChannel first in default strategy

Open bee64 opened this issue 2 years ago β€’ 7 comments

Fix for Issue 33 In the default strategy, use BroadcastChannel first and fallback to localStorage.

Also fixes karma.conf Headless Chrome usage.

bee64 avatar Jul 16 '21 16:07 bee64

@xanf please review! πŸ˜€

bee64 avatar Jul 16 '21 16:07 bee64

Will do tomorrow :) having birthday today, lol

ΠΏΡ‚, 16 июл. 2021 Π³., 19:46 Bradley Smith @.***>:

@xanf https://github.com/xanf please review! πŸ˜€

β€” You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/xanf/vuex-shared-mutations/pull/36#issuecomment-881581195, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABRCJJYSS7JKCOGVZAYZXTTYBO6TANCNFSM5AP5BICQ .

xanf avatar Jul 16 '21 17:07 xanf

Happy birthday!! 🍰 πŸŽ‰

bee64 avatar Jul 16 '21 17:07 bee64

@Brad-- done, I will release it with npm tomorrow

Thank you for your effort!

xanf avatar Jul 20 '21 18:07 xanf

πŸš€

bee64 avatar Jul 20 '21 19:07 bee64

@xanf seems like you forgot to merge this pr :D

Dubzer avatar Aug 16 '21 05:08 Dubzer

So.. it appears that this was never merged despite @xanf saying it had been? I see no commits since 2019.

Any chance you could merge this PR and a few others pretty please @xanf ?

Many thanks

vesper8 avatar May 17 '22 13:05 vesper8