Marco Mastropaolo comments

Results 21 comments of


                                            Marco Mastropaolo

Exception rethrow might lose part of the call stack on Unity

.net works ok. Seems like a mono bug.

Wrong extension methods caching?

Yes, sounds suspicious .. I'll check asap. Thanks

Wrong extension methods caching?

No repro :( I've added Interop_Overloads_Twice_ExtMethods1 and Interop_Overloads_Twice_ExtMethods2 tests in UserDataOverloadsTest.cs ... let me know if you still have the problem or what is missing from the test...

Implemented `suspicious_to_owned` lint to check if `to_owned` is called on a `Cow`

Converted to draft to fix the test issue (that for some reason doesn't manifest locally :( )

Implemented `suspicious_to_owned` lint to check if `to_owned` is called on a `Cow`

CI is happy now, marking ready for review.

Implemented `suspicious_to_owned` lint to check if `to_owned` is called on a `Cow`

Thanks, running this on the top 1000 crates makes sense. Quick-xml is certainly conscious of the caveats and in some way perpetrates the same `to_owned` vs `into_owned` argument (see [comment...

Implemented `suspicious_to_owned` lint to check if `to_owned` is called on a `Cow`

You're probably right that suggesting to use `clone` is better as it would not suggest to have a different semantic than the one written but suggest to use a more...

Implemented `suspicious_to_owned` lint to check if `to_owned` is called on a `Cow`

I rebased and changed the wording so that it's less opinionated between `clone()` and `into_owned`, and now it suggests both replacements, "depending on intent". Let me know if it's fine...

Implemented `suspicious_to_owned` lint to check if `to_owned` is called on a `Cow`

Rebased on the latest master but forgot to update_lints 🤷‍♂️ Fixed the mistake and exercising CI again.

Implemented `suspicious_to_owned` lint to check if `to_owned` is called on a `Cow`

Not sure about the merge failure here. I tried to do (*) a rebase on the latest master and it went without conflicts; cargo tests also not failing after it,...