GooglePlayServicesComponents icon indicating copy to clipboard operation
GooglePlayServicesComponents copied to clipboard

[Samples] AdsLite sample AdActivity.OnCreate is sealed

Open moljac opened this issue 5 years ago • 1 comments

Google Play Services Version

  • [x] GPS-FB with AndroidX dependencies (versions 1xx.yyyy.zz)

  • [] GPS-FB with Android.Support (legacy) dependencies (versions 71.yyyy.zz)

Describe your Issue

MainActivity.cs(21,33): error CS0239: 'MainActivity.OnCreate(Bundle)': cannot override inherited member 'AdActivity.OnCreate(Bundle)' because it is sealed [D:\X\GPS-FB-ax\samples\com.google.android.gms\play-services-ads-lite\AdsLiteSample\AdsLiteSample.csproj]

Minimal Repro Code Sample

Samples migrated to AndroidX

Include any relevant Exception Stack traces, build logs, adb logs:

MainActivity.cs(21,33): error CS0239: 'MainActivity.OnCreate(Bundle)': cannot override inherited member 'AdActivity.OnCreate(Bundle)' because it is sealed [D:\X\GPS-FB-ax\samples\com.google.android.gms\play-services-ads-lite\AdsLiteSample\AdsLiteSample.csproj]

moljac avatar Jun 18 '20 08:06 moljac

Sample needs to be rewritten:

Making AdActivity non sealed (non final) causes ACW errors:

    <!--
    causing ACW errors:
    ./samples/com.google.android.gms/play-services-ads-lite/AdsLiteSample/obj/Debug/android/src/crc6449ab38c9a8eed94c/MainActivity.java(36,36): 
    Error JAVAC0000:  error: cannot inherit from final AdActivity
    extends com.google.android.gms.ads.AdActivity
    (JAVAC0000) (AdsLiteSample) javac
    <attr
        path="/api/package[@name='com.google.android.gms.ads']/class[@name='AdActivity']"
        name="final"
        >
        false
    </attr>
    -->

moljac avatar Sep 30 '20 11:09 moljac