FacebookComponents icon indicating copy to clipboard operation
FacebookComponents copied to clipboard

Update ios sdk to version 12.2.0

Open thisisthekap opened this issue 3 years ago • 43 comments

The iOS bindings need to be updated to support new ad measurement features which were mandatory after the introduction of iOS 14.5.

@SotoiGhost As @dalexsoto informed me, you are the original maintainer of this repository. If needed, I am happy to help with doing the update, as we need the update rather sooner than later.

@SotoiGhost Please let me know how we best proceed on this one.

thisisthekap avatar Dec 01 '21 12:12 thisisthekap

@thisisthekap Thanks for the heads up. Please, feel free to do the update if possible, that would be a great help for us! I have this update in my TODO list, but I'm attending another task before getting into this one. Let me know if you decide to do the update. Thank you in advance!

SotoiGhost avatar Dec 02 '21 19:12 SotoiGhost

@SotoiGhost When do you think you would be going to do the upgrade?

Unfortunately, I got a lot on my plate as well as of now.

thisisthekap avatar Dec 02 '21 19:12 thisisthekap

@SotoiGhost We also need the update. It is important so that we can use aggregated event measurement for apps. But unfortunately I don't know how to do the binding update

To configure Aggregated Event Measurement for your app: Update to Facebook SDK for iOS version 11.2.0 or above to configure your app events.

Source: https://www.facebook.com/business/help/2750680505215705?id=428636648170202

Huaba93 avatar Dec 03 '21 07:12 Huaba93

I'll start doing the update for this

SotoiGhost avatar Dec 06 '21 22:12 SotoiGhost

@SotoiGhost thank you very much 🙏.

ETA? The Christmas sales are just around the corner. 🙈

Huaba93 avatar Dec 07 '21 04:12 Huaba93

@SotoiGhost any news? or is there anything I can help you with? eg. testing?

Huaba93 avatar Dec 10 '21 06:12 Huaba93

@SotoiGhost Any news on your timeline?

thisisthekap avatar Dec 16 '21 08:12 thisisthekap

Any news ?

MateuszLas421 avatar Jan 11 '22 09:01 MateuszLas421

@MateuszLas421 @SotoiGhost @Huaba93 I started working on the bindings myself today.

thisisthekap avatar Jan 11 '22 10:01 thisisthekap

Sorry folks for the long waiting on this. I almost have a working PR for this. I'm hoping to post it by today.

SotoiGhost avatar Jan 11 '22 18:01 SotoiGhost

@SotoiGhost Thanks for that. I'll stop working on that now. I would appreciate better communication on planning and ETAs the next time.

thisisthekap avatar Jan 11 '22 18:01 thisisthekap

@SotoiGhost Do you need some assistance e.g. in testing the updated version?

thisisthekap avatar Jan 14 '22 06:01 thisisthekap

Folks, here's the PR for v12.2.0 update. I'll wait for the approval of the team. Meanwhile, you can build the nuget packages by running dotnet cake -t=nuget inside of the Facebook.iOS folder of my fork if you want to test them.

SotoiGhost avatar Jan 14 '22 17:01 SotoiGhost

I tried to update to 12.2.0 today and received the following error message:

Severity Code Description Project File Line Suppression State Error Could not find a part of the path 'C:\Users\tigre.nuget\packages\xamarin.facebook.sharekit.ios\12.2.0\lib\xamarinios10\Facebook.ShareKit.resources\FBSDKShareKit.xcframework\ios-arm64_i386_x86_64-simulator\FBSDKShareKit.framework\Modules\FBSDKShareKit.swiftmodule\arm64-apple-ios-simulator.swiftdoc'.

Any ideas?

tigreye007 avatar Jan 20 '22 17:01 tigreye007

@tigreye007 Do you experience this issue when building your project?

thisisthekap avatar Jan 21 '22 08:01 thisisthekap

@tigreye007 Do you experience this issue when building your project?

I got this when I tried to upgrade the package via nuget (from 9.0.1.5 => 12.2.0)

tigreye007 avatar Jan 21 '22 15:01 tigreye007

My guess is that it doesn't like the path length (263 characters)

tigreye007 avatar Jan 21 '22 15:01 tigreye007

I tried to update to 12.2.0 today and received the following error message:

Severity Code Description Project File Line Suppression State Error Could not find a part of the path 'C:\Users\tigre.nuget\packages\xamarin.facebook.sharekit.ios\12.2.0\lib\xamarinios10\Facebook.ShareKit.resources\FBSDKShareKit.xcframework\ios-arm64_i386_x86_64-simulator\FBSDKShareKit.framework\Modules\FBSDKShareKit.swiftmodule\arm64-apple-ios-simulator.swiftdoc'.

Any ideas?

Same problem

AlexanderTretyackov avatar Jan 28 '22 13:01 AlexanderTretyackov

Same issue here

VanjaPopovic avatar Feb 03 '22 07:02 VanjaPopovic

Same problem

"C:\Users\HomeIT.nuget\packages\xamarin.facebook.sharekit.ios\12.2.0\lib\xamarinios10\Facebook.ShareKit.resources\FBSDKShareKit.xcframework\ios-arm64_i386_x86_64-simulator\FBSDKShareKit.framework\Modules\FBSDKShareKit.swiftmodule\arm64-apple-ios-simulator.swiftdoc".

denisminb avatar Feb 10 '22 10:02 denisminb

Has anyone found a workaround for this yet?

tigreye007 avatar Feb 14 '22 16:02 tigreye007

Has anyone found a workaround for this yet?

I work on windows 10, so there is a way to enable long paths,, but anyway I can't build my project with that nuget because of such error: /usr/bin/ditto C:/n/xamarin.facebook.corekit.ios/12.2.0/buildTransitive/../lib/xamarinios10/Facebook.CoreKit.resources/FBSDKCoreKit.xcframework/ios-arm64_armv7/FBSDKCoreKit.framework/../dSYMs/FBSDKCoreKit.framework.dSYM/ bin/iPhone/Release/[BioGenom.iOS.app/../FBSDKCoreKit.framework.dSYM](http://biogenom.ios.app/FBSDKCoreKit.framework.dSYM) (Идентификатор задачи TaskId:239) 2> ditto: Cannot get the real path for source 'C:/n/xamarin.facebook.corekit.ios/12.2.0/buildTransitive/../lib/xamarinios10/Facebook.CoreKit.resources/FBSDKCoreKit.xcframework/ios-arm64_armv7/FBSDKCoreKit.framework/../dSYMs/FBSDKCoreKit.framework.dSYM/' (Идентификатор задачи TaskId:239) 2>C:\Program Files (x86)\Microsoft Visual Studio\2019_Latest\MSBuild\Xamarin\iOS\Xamarin.Shared.targets(2050,3): error MSB6006: "ditto" завершилась с кодом 1.

AlexanderTretyackov avatar Feb 14 '22 17:02 AlexanderTretyackov

Has anyone found a workaround for this yet?

no, not solved yet

denisminb avatar Feb 16 '22 12:02 denisminb

Has anyone found a workaround for this yet?

I work on windows 10, so there is a way to enable long paths,, but anyway I can't build my project with that nuget because of such error: /usr/bin/ditto C:/n/xamarin.facebook.corekit.ios/12.2.0/buildTransitive/../lib/xamarinios10/Facebook.CoreKit.resources/FBSDKCoreKit.xcframework/ios-arm64_armv7/FBSDKCoreKit.framework/../dSYMs/FBSDKCoreKit.framework.dSYM/ bin/iPhone/Release/[BioGenom.iOS.app/../FBSDKCoreKit.framework.dSYM](http://biogenom.ios.app/FBSDKCoreKit.framework.dSYM) (Идентификатор задачи TaskId:239) 2> ditto: Cannot get the real path for source 'C:/n/xamarin.facebook.corekit.ios/12.2.0/buildTransitive/../lib/xamarinios10/Facebook.CoreKit.resources/FBSDKCoreKit.xcframework/ios-arm64_armv7/FBSDKCoreKit.framework/../dSYMs/FBSDKCoreKit.framework.dSYM/' (Идентификатор задачи TaskId:239) 2>C:\Program Files (x86)\Microsoft Visual Studio\2019_Latest\MSBuild\Xamarin\iOS\Xamarin.Shared.targets(2050,3): error MSB6006: "ditto" завершилась с кодом 1.

I also tried to include long paths in win10, manually create the required folder, but nothing helps

denisminb avatar Feb 16 '22 12:02 denisminb

Same issue here, solutions? We are stuck with 9.0.1.5 but it's not working anymore.

alessandromanfredi avatar Feb 23 '22 10:02 alessandromanfredi

Folks, does this happen using Visual Studio or also with command line?

If this is happening with Visual Studio, please, clear your NuGet cache, delete the bin and obj folder and do a restore from command line before opening the solution with VS. Let me know if this works for you.

SotoiGhost avatar Feb 23 '22 18:02 SotoiGhost

Folks, does this happen using Visual Studio or also with command line?

If this is happening with Visual Studio, please, clear your NuGet cache, delete the bin and obj folder and do a restore from command line before opening the solution with VS. Let me know if this works for you.

I clear my NuGet cache, deleted the the bin and obj folder, restored the packages via nuget restore 'path my project' , before opening the project from visual studio, then opened the project and tried to update the package, but the error message is still the same: C:\Users\HomeIT\.nuget\packages\xamarin.facebook.sharekit.ios\12.2.0\lib\xamarinios10\Facebook.ShareKit.resources\FBSDKShareKit.xcframework\ios-arm64_i386_x86_64-simulator\FBSDKShareKit.framework\Modules\FBSDKShareKit.swiftmodule\arm64-apple-ios-simulator.swiftdoc

denisminb avatar Feb 23 '22 19:02 denisminb

@denisminb Try updating your .csproj or your packages.config, setting to the most recent version of FB package by hand and then do the restore before opening VS.

SotoiGhost avatar Feb 23 '22 19:02 SotoiGhost

@denisminb Try updating your .csproj or your packages.config, setting to the most recent version of FB package by hand and then do the restore before opening VS.

I understand you correctly, manually edit the file .csproj or your packages.config, change the version of the iOS packages from 9.0.1.5 to 12.2.0 and then restore?

denisminb avatar Feb 23 '22 19:02 denisminb

@denisminb Yep, and don't forget to clean your NuGet cache, I think deleting the bin and obj is optional, but just in case.

SotoiGhost avatar Feb 23 '22 20:02 SotoiGhost