Essentials icon indicating copy to clipboard operation
Essentials copied to clipboard
verified publisher icon xamarin

Fix Styles on Sample Project

Open dimonovdd opened this issue 5 years ago • 3 comments

This fix changes the display of Pickers and Text Editors.

Before this fix, it looked like this:

Picker Entry Editor
entry entry editor

dimonovdd avatar Jan 27 '21 20:01 dimonovdd

After:

Picker Entry Editor
telegram-cloud-photo-size-2-5229176396197245787-y telegram-cloud-photo-size-2-5229176396197245786-y telegram-cloud-photo-size-2-5229176396197245785-y

dimonovdd avatar Jan 28 '21 10:01 dimonovdd

@mattleibow I also noticed problems on iOS with Dark mode. I fixed it, but did it in Light mode style.

Before
Home Share Browser
After
Home Share Browser

dimonovdd avatar Feb 19 '21 21:02 dimonovdd

Hi, @mattleibow Is there any problem with this PR? If there are problems, I am ready to fix them.

dimonovdd avatar Feb 28 '21 08:02 dimonovdd

A good style is definitely important and sorry for not giving this the attention it deserves. I don't think at this point We want to invest too much time in this. I do very much appreciate the time and effort that you put into this though! Thank you!

jfversluis avatar Feb 14 '23 08:02 jfversluis