proguard_xamarin.cfg and xamarin.android.google.billingclient3.0.0

[gmck]

I had to add the following to my proguard.cfg to eliminate a crash in my release version when clicking the PurchaseButton which initiates the purchase on Google Play

-keep class androidx.core.app.CoreComponentFactory -keep class com.android.billingclient.api.ProxyBillingActivity

Could that not be added to proguard_xamarin.cfg?

[moljac]

@gmck Thanks for the feedback.

Could that not be added to proguard_xamarin.cfg?

It could, but I barely keep up with updates of AX and GPS-FB-MLKit bindings. I wish I could have more time to work on samples to get to know APIs I bind. Then I would detect such things and in bindings improvements I could add such improvements to packages.

Now few questions:

• Is there a reason to raise the issue in AX repo? billingclient is not in this repo or GPS-FB-MLKit https://github.com/xamarin/XamarinComponents/tree/main/Android/GoogleBillingClient
• How to integrate proguard_xamarin.cfg? Nuget of billingclient? Sample templates? Both are not under my jurisdiction and responsibility. I mean if I get some air I will (most likely) do it, but no promises.

[jpobst]

We include any proguard.txt files that Google ship with their libraries. As they know their libraries better than us, we defer to their judgement here.

It does look like they now include this is their latest billingclient:

-keepnames class com.android.billingclient.api.ProxyBillingActivity