vue-good-table icon indicating copy to clipboard operation
vue-good-table copied to clipboard

Add column filters component

Open p0psicles opened this issue 4 years ago • 13 comments

Use a column filter by using the vgt option: :column-filter-options="{ enabled: true }"

column-filters

p0psicles avatar Feb 28 '21 10:02 p0psicles

@xaksis can I get some feedback on this one?

p0psicles avatar Mar 03 '21 14:03 p0psicles

hey @p0psicles. Yeah, I've looked this over but I'm trying to think about how we can make this an optional include. Basically, create an infrastructure for table plugins. (I know I've discussed this in the past) This is a prefect use-case for it. I haven't had a chance to explore it in detail yet though... would be happy to get some help.

xaksis avatar Mar 03 '21 15:03 xaksis

Ohh I've also never done anything like this. Wouldn't know where to start tbh

p0psicles avatar Mar 03 '21 16:03 p0psicles

Ha! I'm in the same boat. I'm taking the next week off (after a LOOONG time) will try and come up with something.

xaksis avatar Mar 03 '21 16:03 xaksis

IMO it's already an optional component. the UI component is a separate vue component. Which can be optionally used.

Would you want to create and maintain separate plugin repo's for plugins? Like have a user need to do yarn add vgt-plugin-column-filter?

p0psicles avatar Mar 03 '21 16:03 p0psicles

I wouldn't. You would! The idea is to democratize the eco-system around the table. So people can make/maintain their own extensions, with the base being a lean VGT with core functionalities. That'd be a decent way to scale, without one person becoming the bottleneck for multiple extensions. What do you think?

xaksis avatar Mar 03 '21 16:03 xaksis

Yeah sounds nice. Little bit idealistic. I think we'd need to start to start with an existing feature and flesh that out. And preferably have vgt offer an api that can be used by the plugin. But again. No idea how. But I'm always up for learning new stuff.

Plus I really need a number of features. As running my fork is a pita. As I need to rebase and resolve conflicts with each release.

p0psicles avatar Mar 03 '21 16:03 p0psicles

Doing some thinking. Maybe vue 3 composition api could help here.

p0psicles avatar Mar 03 '21 17:03 p0psicles

@xaksis I'm giving it a go using scoped slots. I'll push the changes in this pr

p0psicles avatar Mar 09 '21 08:03 p0psicles

@xaksis if you could give me some feedback I'm willing to do some work on this

p0psicles avatar Mar 11 '21 07:03 p0psicles

This requires more thinking through. I will update here when I have some time to work through it.

xaksis avatar Mar 12 '21 14:03 xaksis

Sure. tnx for the update

p0psicles avatar Mar 12 '21 14:03 p0psicles

It has been a few weeks. Any update on this?

p0psicles avatar Apr 06 '21 10:04 p0psicles