Dmitrii Okunev

Affected functions: - sync_idle_dosync_collectedevents_commitpart - sync_initialsync - sync_dosync_exec Related issues: #50

Functions so_call_rsync, so_call_rsync_thread, so_call_sync, so_call_sync_thread, sync_exec_thread and sync_exec have a lot of similarities. This functions should be deduplicated.

Don't pass "index_p" and so on if "ctx_p" is already passed.

``` main.c:1014: Medium: signal sync.c:3596: Medium: signal When setting signal handlers, do not use the same function to handle multiple signals. There exists the possibility a race condition will result...

Use environment variables instead of arguments while calling external sync-handler

3

Don't call sync-handler this way: "/sync/handler/path rsynclist /path/to/include-list /path/to/exclude-list" Just call "/sync/handler/path" with predefined environment variables (with "setenv()"). @bircoph, what do you think?

rules_search_getperm(): Conditional jump or move depends on uninitialised value(s)

2

valgrind reports about "Conditional jump or move depends on uninitialised value(s)" on printf_ddd() calling in the loop in function rules_search_getperm(). However it report about it even if the line in...

global section in config file

2

Are we need global section in config file?

valgrind reports about memleak on g_key_file_load_from_file() ==28818== 32 bytes in 1 blocks are possibly lost in loss record 8 of 35 ==28818== at 0x4C29C64: calloc (vg_replace_malloc.c:593) ==28818== by 0x4E80998: g_malloc0...

GKeyFile created by g_key_file_new() is free'd by g_key_file_free(). However we can see next problem: ==27263== 240 bytes in 1 blocks are possibly lost in loss record 18 of 35 ==27263==...