Xavier Dupré comments

Results 287 comments of


                                            Xavier Dupré

addition of group > 1 in test and in backend

[chachaleo](https://github.com/chachaleo), I created another PR with your changes https://github.com/onnx/onnx/pull/6175 and updated only the necessayr data, could you review it?

model.ByteSize() is negative when converting microsoft/phi2 model

How do you use ByteSize()? Maybe we can implement a function which returns the result you build with it. I don't think protobuf will update its API since it is...

ImportError: cannot import name 'FEATURE_IMPORTANCE_TYPE_MAPPER' from 'lightgbm.basic'

Not yet. The fix will be done in onnxmltools. The documentation of sklearn-onnx has been update to reflect that: https://onnx.ai/sklearn-onnx/auto_tutorial/plot_gexternal_lightgbm.html.

Error on mlprodict runtime vs onnxruntime

Could you raise an issue on onnx repository? Most of the python runtime implemented in onnx comes from this package but it is maintained by the community as opposed to...

Exclude test data from the Python package

I don't know what the status is for this PR. On my side, I still think it is useful. An easy way would be to have two package, onnx and...

Update transpose doc

No clue. I don't remember seeing them when I reviewed the PR.

Adding sparse_coo_tensor

This is already a way to create a sparse tensor in onnx (see [Constant](https://onnx.ai/onnx/operators/onnx__Constant.html)). It looks like a converter issue, isn't it?