dashmap icon indicating copy to clipboard operation
dashmap copied to clipboard

update hashbrown to v0.15

Open conradludgate opened this issue 1 year ago • 1 comments

hashbrown removed the RawTable API, requiring dashmap to use HashTable instead. This was the API I wanted dashmap 6 to use initially as the shards being RawTable means unsafe is often necessary.

Due to needing some more RwLock mapping support when it comes to HashTable iterators and such, I designed the RwLockReadGuardDetached which cleans up a fair amount of pointer shenanigans around the codebase.

In the process, I also decided to remove all the unsafe impl Send and make the RawRwLock guard be Send instead, as it seemingly is intended to be.

miri with both stacked and tree borrows seem happy still, and there's a lot less unsafe in the process.

conradludgate avatar Oct 16 '24 10:10 conradludgate

This PR should be split up - #10 is no longer valid and thus I have removed the SharedValue abstraction as well.

conradludgate avatar Oct 16 '24 13:10 conradludgate

cargo-audit now raises a warning for [email protected] https://github.com/rust-lang/hashbrown/issues/576 . Any plans for this PR?

atezet avatar Dec 04 '24 20:12 atezet

(Note that hashbrown/borsh is irrelevant to dashmap though, and probably most hashbrown users in general.)

cuviper avatar Jan 08 '25 21:01 cuviper

Superceded by #324

conradludgate avatar Feb 01 '25 13:02 conradludgate