xamarin-forms-tab-badge icon indicating copy to clipboard operation
xamarin-forms-tab-badge copied to clipboard

Update BadgedTabbedPageRenderer.cs

Open ndastur opened this issue 7 years ago • 2 comments

Saves users of the nuget package having to make source changes

ndastur avatar May 26 '17 13:05 ndastur

Hi, @ndastur thanks for the PR. Actually I had this in the beginning and it worked fine, except for one case: when the user had his own custom renderer and wanted to inherit from the badge renderer. The order in which XF registers renderers is somewhat unclear and I had the case where the rendere registered in the plugin overrode the app specific custom renderer. I don't want to merge these PRs until we can confirm that this is not an issue.

xabre avatar Jun 27 '17 15:06 xabre

That's really interesting. I believe "most" plugins do use the technique in the pull requests on the basis that I haven't come across any other plugins that require that sort of manual intervention. I also think that the majority of users just want to "use" the plugin and what you describe is a real edge case.

ndastur avatar Jun 28 '17 21:06 ndastur