Christian Flothmann

Results 531 comments of Christian Flothmann

I am a bit worried that merging this would break existing applications that rely on the fact that their listeners are not called on forms that have the `inherit_data` option...

Do you have a concrete use case in mind where removing this limitation would be useful?

Can you create a small example application that allows to reproduce your issue?

Marking all these tests as legacy is not the way to go. Instead all the tests should be updated the same way an Symfony user would have to update their...

Looking at your updated `composer.json` file, you removed the `symfony/messenger` dependency. Was that intended?

Should this be merged into the `4.4` branch?

Will the error output look differently after this change? If so, can you share before and after screenshots?

@maxbeckers what do you think?

I did the rebase and switched the target branch to `4.4`.