Pavel Djundik

@bgrainger Yeah that's what I ended up doing, but is this still a valid issue on Dapper's side?

Would also be great to introduce a warning for functions like `curl_close` and `imagedestroy` to replace them with `unset` calls.

This is still an issue on 3.0.8. What's worse is that the scrollbar is not visible (Windows 11) unless you are hovering on the history panel, so it is impossible...

I believe this is caused by this code: https://github.com/desktop/desktop/blob/34d391b60e9189fca75a62394ea4422e3a5ca00c/app/src/lib/menu-update.ts#L365-L368 It doesn't take into account that the popup can be hidden. I briefly debugged it, and it keeps calling `getAllMenusDisabledBuilder` as...

Any point if it returns less data?

So removing it from `TryConvertValueTo` should be correct then.

You do, which is more helpful due to a better exception message: eb5d13f301d1487836702070c36fb77b95a5a3ec

@yaakov-h Can you give this an initial review pass? I especially want to hear about stuff around handling arrays and flags.

Does it not work if your `FileLoader` simply returns an empty object? This needs a test too.

Perhaps instead of removing all the checks there should be a way for file loader to accept empty objects. Have you tried an empty root object too?