Slimefun-Resourcepack icon indicating copy to clipboard operation
Slimefun-Resourcepack copied to clipboard

Re-name some files for ID consistency

Open JustAHuman-xD opened this issue 1 year ago • 2 comments

Describe the problem: I develop a mod called SlimefunEssentials, one of its features is adding slimefun items and recipes to jei, rei, and emi, a heavily requested feature was adding support for custom model data.

So I've been working on the feature and have got it nearly complete. The problem is that it detects the custom model data only if the model name is the same as the slimefun id.

In the case of your resource pack that is only true part of the time. So I was wondering if you'd be up just to renaming the files, I can make the PR myself if you'd like.

I also completely get it if you don't want to make that change so no problem regardless!

JustAHuman-xD avatar Apr 14 '24 17:04 JustAHuman-xD

I selected the question label not bug label but it appears to have decided not to add that one lol

JustAHuman-xD avatar Apr 15 '24 13:04 JustAHuman-xD

Hi, welcome to PR this! I don't mind something break, because I always break something :laughing:

xMikux avatar Apr 16 '24 04:04 xMikux

There is no report about ID rename issues, so it is safe to close this.

Thanks!

xMikux avatar Sep 27 '24 12:09 xMikux