Marcel Märtens
Marcel Märtens
I can have a look into these points after #58 got merged. Not a huge fan of gigantic refactoring PRs, rather do it in smaller steps. What do you think...
@besok any comment at this ? maybe any way to make communication easier than via github ? Like discord ?
I wanted to search in some existing json `Value` however i can't pass a `&Value` to the struct, so i would need to copy it. One could think about extending...
Just had a look, it seems like #62 adds a cache for regex, imo this is is not necessary when doing it like in this PR. You dont need a...
I'll try to explain, I don't remember the internals from this crate as the PR is a bit older. So mostly #61 complained about the crate beeing slow. And they...
Okay, just had some refactoring and mid into it i noted what we were talking about, the regex is actually executed as part of the search on not when creating...
Here is some ugly code that statically compiles the regex, when the `JsonPathInst` is generated: https://github.com/besok/jsonpath-rust/commit/e527958315967cf13f65a887403d9677292028cc compilation time goes up by: JsonPathInst generation time: [76.777 µs 76.844 µs 76.915 µs]...
sorry, non-native speaker here. Is this now a good thing that its compiled with the jspath or a bad thing ?
in that example: ```rust let path = JsonPathInst::from_str('$.[?(@.field == '[a-zA-Z]')]').unwrap(); for _ in 0..1000 { // actually 1000 different jsons: let json = json!({ "field":"abcXYZ", }); let x = jsonpath_rust::find(&path,...
Good point, I haven't though about that yet. I don't necessarily want the user to build a cache in the sense of a HashMap. But I want the user be...