starknet-rs

starknet-rs copied to clipboard

Unify `pub enum TransactionStatus` variants

1

At the moment, we have multiple `TransactionStatus` enum variants around the codebase: https://github.com/xJonathanLEI/starknet-rs/blob/4dbc1692d4f295de803484181e07803201528922/starknet-core/src/types/mod.rs#L178-L183 https://github.com/xJonathanLEI/starknet-rs/blob/4dbc1692d4f295de803484181e07803201528922/starknet-core/src/types/codegen.rs#L1536-L1545 https://github.com/xJonathanLEI/starknet-rs/blob/4dbc1692d4f295de803484181e07803201528922/starknet-providers/src/sequencer/models/transaction_receipt.rs#L35-L51 I think this should be unified, probably in core to have a single variant for...

tcoratger

UDC: Contract deployment selector mismatch

1

Currently starknet.rs uses `deployContract` (camelCase): https://github.com/xJonathanLEI/starknet-rs/blob/36ec1d681fc2917ca4857d14ce262ed7c2b60a7a/starknet-contract/src/factory.rs#L15-L16 OpenZeppelin has been using `deploy_contract` (snake_case) as the UDC method name since v0.11.0: https://github.com/OpenZeppelin/cairo-contracts/blob/a83f36b23f1af6e160288962be4a2701c3ecbcda/src/presets/universal_deployer.cairo#L38 Should someone change something?

FabijanC

Extend JSON-RPC transport capabilities for batch requests

1

### Extend JSON-RPC Transport Capabilities for Batch Requests #### Context Currently, the `JsonRpcRequest` structure in https://github.com/xJonathanLEI/starknet-rs/blob/master/starknet-providers/src/jsonrpc/transports/http.rs allows for making JSON-RPC requests with a specified method. To support the needs of...

tcoratger

jbcaron

Add more clippy lint rules

2

In order for the codebase to be more Rust idiomatic and to improve some part/performance, we could enforce more clippy lint rules at a root level. See for example what...

tcoratger

Divide by zero panics in `bigint_mul_mod_floor` and `mul_mod_floor` if modulus set to 0

1

Hey Jonathan, During code review, we (@fuzzinglabs) found a case making starknet-rs crash. The crash occurs when trying to call the `bigint_mul_mod_floor` function in `starknet-crypto`. If the `modulus` parameter of...

pventuzelo

xJonathanLEI

bug(felt): Felt is not zeroized for sensitive cryptographic operations

1

### Is there an existing issue? - [X] I have searched the existing issues ### Motivation `Felt` is not zeroized on drop which might leak sensitive information into RAM, notably...

Trantorian1

incoming breaking change on Ledger

6

gm @xJonathanLEI there is an incoming breaking change on Ledger side cf https://github.com/LedgerHQ/starknet-js-client/releases/tag/2.3.0 the release data is not know yet but ETA is 2 weeks.

adrienlacombe

Request: SNIP-9 - OutsideExecution

2

Would be great to have support to interact with SNIP-9 compatible wallets to be able to construct outside executions and submit them with ease. [Starknet Proposal Discussion](https://community.starknet.io/t/snip-outside-execution/101058) [Argent Docs](https://github.com/argentlabs/argent-contracts-starknet/blob/main/docs/outside_execution.md)

machuwey