VulkanMod icon indicating copy to clipboard operation
VulkanMod copied to clipboard
verified publisher icon xCollateral

Fix polygon mode mixin using face as mode

Open Fox2Code opened this issue 1 year ago • 4 comments

Fix compatibility issue with Not-Enough-Crashes, see:

  • https://github.com/natanfudge/Not-Enough-Crashes/blob/1.21/common/src/main/java/fudge/notenoughcrashes/utils/GlUtil.java#L39
  • https://registry.khronos.org/OpenGL-Refpages/gl4/html/glPolygonMode.xhtml

Fox2Code avatar Oct 05 '24 13:10 Fox2Code

This PR fixes Not-Enough-Crashes compatibility issues.

Fox2Code avatar Oct 05 '24 13:10 Fox2Code

@xCollateral can you review this please.

Fox2Code avatar Oct 13 '24 13:10 Fox2Code

v2:

  • Rebased to dev branch
  • Removed null check for GlTexture.texParameteri, this will be moved into another PR

Fox2Code avatar Oct 14 '24 15:10 Fox2Code

Null check has been replaced by proper implementation:

  • https://github.com/xCollateral/VulkanMod/pull/526

Fox2Code avatar Oct 17 '24 20:10 Fox2Code

Note: @xCollateral want to do the commit himself, I keep this PR as a reminder for him.

Fox2Code avatar Nov 19 '24 15:11 Fox2Code