VulkanMod icon indicating copy to clipboard operation
VulkanMod copied to clipboard

Blocks (and non-blocks) not breaking

Open thasave14 opened this issue 10 months ago • 17 comments

I'm on this minecraft world with my friends on telegram (ignore their voices, it's italian) and there's this bug. All my specs and info are on the vids.

https://github.com/xCollateral/VulkanMod/assets/93542339/c2642b74-7780-41bc-bd29-efb99309d8f5 https://github.com/xCollateral/VulkanMod/assets/93542339/7cbb39d1-277e-4fce-acf5-2d55a65275df

thasave14 avatar Apr 08 '24 19:04 thasave14

oh and i found out that if i look to a non complete block i can see the blocks under it like x-ray. Same specs and everything

thasave14 avatar Apr 08 '24 19:04 thasave14

https://github.com/xCollateral/VulkanMod/issues/402 same problem here with latest v4.0 1.20.4 on 1.20.4

Daxy7 avatar Apr 19 '24 16:04 Daxy7

the blocks under it like

mine issue a little different and have been fixed by removing ServerCore

melamit avatar Apr 23 '24 10:04 melamit

yea but i dont have servercore

thasave14 avatar Apr 24 '24 13:04 thasave14

I don't have server core this still happends exactly like the video

Dashy22 avatar Apr 28 '24 01:04 Dashy22

https://github.com/xCollateral/VulkanMod/assets/91396482/0d26c511-805b-4d3d-baf9-89886cf7421d I managed to fix it. https://github.com/xCollateral/VulkanMod/assets/91396482/e806d59d-0625-4971-b4f9-c9c98f245bba By disabling all optimizations and turning render/simulation distance to lowest.

Daxy7 avatar Apr 29 '24 09:04 Daxy7

Edit: just changing chunk render to 2 fixed the issue. after re-putting to 12.

Daxy7 avatar Apr 29 '24 13:04 Daxy7

Send logs and steps to reproduce, please.

xCollateral avatar Apr 29 '24 15:04 xCollateral

the steps are easy i think, launch the mod, go on a random chunk, break blocks, for some reason it worked only on some chunks, and second, about the logs, i think i might have found something:

"[20:32:17] [Worker-Main-2/WARN]: Profile contained invalid signature for textures property (profile id: 93bf26d1-7a2d-3fbe-8354-01e4b39ab6e2) [20:32:59] [Builder-0/ERROR]: Uncaught exception in thread "Builder-0" java.lang.ArrayIndexOutOfBoundsException: Index 31 out of bounds for length 27 at net.vulkanmod.render.chunk.build.RenderRegion.method_8314(RenderRegion.java:150) ~[VulkanMod_1.20.4-0.4.0.jar:?] at net.vulkanmod.render.chunk.build.light.data.LightDataAccess.compute(LightDataAccess.java:107) ~[VulkanMod_1.20.4-0.4.0.jar:?] at net.vulkanmod.render.chunk.build.light.data.ArrayLightDataCache.get(ArrayLightDataCache.java:71) ~[VulkanMod_1.20.4-0.4.0.jar:?] at net.vulkanmod.render.chunk.build.light.data.LightDataAccess.get(LightDataAccess.java:63) ~[VulkanMod_1.20.4-0.4.0.jar:?] at net.vulkanmod.render.chunk.build.light.data.LightDataAccess.get(LightDataAccess.java:69) ~[VulkanMod_1.20.4-0.4.0.jar:?] at net.vulkanmod.render.chunk.build.light.flat.FlatLightPipeline.getLightmap(FlatLightPipeline.java:61) ~[VulkanMod_1.20.4-0.4.0.jar:?] at net.vulkanmod.render.chunk.build.light.flat.FlatLightPipeline.calculate(FlatLightPipeline.java:37) ~[VulkanMod_1.20.4-0.4.0.jar:?] at net.vulkanmod.render.chunk.build.BlockRenderer.renderModelFace(BlockRenderer.java:110) ~[VulkanMod_1.20.4-0.4.0.jar:?] at net.vulkanmod.render.chunk.build.BlockRenderer.tessellateBlock(BlockRenderer.java:92) ~[VulkanMod_1.20.4-0.4.0.jar:?] at net.vulkanmod.render.chunk.build.BlockRenderer.renderBatched(BlockRenderer.java:71) ~[VulkanMod_1.20.4-0.4.0.jar:?] at net.vulkanmod.render.chunk.build.task.BuildTask.compile(BuildTask.java:138) ~[VulkanMod_1.20.4-0.4.0.jar:?] at net.vulkanmod.render.chunk.build.task.BuildTask.runTask(BuildTask.java:52) ~[VulkanMod_1.20.4-0.4.0.jar:?] at net.vulkanmod.render.chunk.build.TaskDispatcher.runTaskThread(TaskDispatcher.java:87) ~[VulkanMod_1.20.4-0.4.0.jar:?] at net.vulkanmod.render.chunk.build.TaskDispatcher.lambda$createThreads$0(TaskDispatcher.java:59) ~[VulkanMod_1.20.4-0.4.0.jar:?] at java.lang.Thread.run(Thread.java:833) ~[?:?]"

and if interested i found this too: "[20:30:01] [Render thread/INFO]: GLFW: 3.4.0 Win32 WGL Null EGL OSMesa VisualC DLL".

and of course the mod i used: "[20:29:24] [main/INFO]: Loading 123 mods: - badoptimizations 2.1.0 - c2me 0.2.0+alpha.11.65 |-- c2me-base 0.2.0+alpha.11.65 |-- c2me-client-uncapvd 0.2.0+alpha.11.65 |-- c2me-fixes-chunkio-threading-issues 0.2.0+alpha.11.65 |-- c2me-fixes-general-threading-issues 0.2.0+alpha.11.65 |-- c2me-fixes-worldgen-threading-issues 0.2.0+alpha.11.65 |-- c2me-fixes-worldgen-vanilla-bugs 0.2.0+alpha.11.65 |-- c2me-notickvd 0.2.0+alpha.11.65 |-- c2me-opts-allocs 0.2.0+alpha.11.65 |-- c2me-opts-chunk-access 0.2.0+alpha.11.65 |-- c2me-opts-chunkio 0.2.0+alpha.11.65 |-- c2me-opts-math 0.2.0+alpha.11.65 |-- c2me-opts-scheduling 0.2.0+alpha.11.65 |-- c2me-opts-worldgen-general 0.2.0+alpha.11.65 |-- c2me-opts-worldgen-vanilla 0.2.0+alpha.11.65 |-- c2me-rewrites-chunk-serializer 0.2.0+alpha.11.65 |-- c2me-rewrites-chunkio 0.2.0+alpha.11.65 |-- c2me-server-utils 0.2.0+alpha.11.65 |-- c2me-threading-chunkio 0.2.0+alpha.11.65 |-- c2me-threading-lighting 0.2.0+alpha.11.65 |-- c2me-threading-worldgen 0.2.0+alpha.11.65 |-- com_electronwill_night-config_core 3.6.5 |-- com_electronwill_night-config_toml 3.6.5 |-- com_ibm_async_asyncutil 0.1.0 |-- net_objecthunter_exp4j 0.4.8 -- org_threadly_threadly 7.0 - centered-crosshair 1.0.6 - clean-debug 0.4.4 - experimentalperformance 0.1.1 |-- io_github_classgraph_classgraph 4.8.162 -- org_openjdk_jol_jol-core 0.17 - fabric-api 0.96.11+1.20.4 |-- fabric-api-base 0.4.36+78d798af4f |-- fabric-api-lookup-api-v1 1.6.49+82b1bb3e4f |-- fabric-biome-api-v1 13.0.16+78d798af4f |-- fabric-block-api-v1 1.0.16+3e2216cb4f |-- fabric-block-view-api-v2 1.0.4+78d798af4f |-- fabric-blockrenderlayer-v1 1.1.46+78d798af4f |-- fabric-client-tags-api-v1 1.1.7+78d798af4f |-- fabric-command-api-v1 1.2.41+f71b366f4f |-- fabric-command-api-v2 2.2.20+78d798af4f |-- fabric-commands-v0 0.2.58+df3654b34f |-- fabric-containers-v0 0.1.86+df3654b34f |-- fabric-content-registries-v0 5.0.15+78d798af4f |-- fabric-convention-tags-v1 1.5.10+78d798af4f |-- fabric-crash-report-info-v1 0.2.23+78d798af4f |-- fabric-data-attachment-api-v1 1.1.4+b90db5744f |-- fabric-data-generation-api-v1 13.2.4+5c0133444f |-- fabric-dimensions-v1 2.1.61+78d798af4f |-- fabric-entity-events-v1 1.6.1+09fc25014f |-- fabric-events-interaction-v0 0.7.1+389931eb4f |-- fabric-events-lifecycle-v0 0.2.74+df3654b34f |-- fabric-game-rule-api-v1 1.0.46+78d798af4f |-- fabric-item-api-v1 2.2.0+d6f2b0844f |-- fabric-item-group-api-v1 4.0.26+58f8c0124f |-- fabric-key-binding-api-v1 1.0.41+78d798af4f |-- fabric-keybindings-v0 0.2.39+df3654b34f |-- fabric-lifecycle-events-v1 2.3.0+a67ffb5d4f |-- fabric-loot-api-v2 2.1.9+78d798af4f |-- fabric-message-api-v1 6.0.5+78d798af4f |-- fabric-mining-level-api-v1 2.1.65+78d798af4f |-- fabric-model-loading-api-v1 1.0.8+78d798af4f |-- fabric-models-v0 0.4.7+9386d8a74f |-- fabric-networking-api-v1 3.1.7+2e5ac5484f |-- fabric-object-builder-api-v1 13.0.14+080016e44f |-- fabric-particles-v1 1.1.7+78d798af4f |-- fabric-recipe-api-v1 2.0.20+78d798af4f |-- fabric-registry-sync-v0 4.0.19+58f8c0124f |-- fabric-renderer-api-v1 3.2.4+78d798af4f |-- fabric-renderer-indigo 1.5.4+78d798af4f |-- fabric-renderer-registries-v1 3.2.53+df3654b34f |-- fabric-rendering-data-attachment-v1 0.3.42+73761d2e4f |-- fabric-rendering-fluids-v1 3.1.1+e761c6694f |-- fabric-rendering-v0 1.1.56+df3654b34f |-- fabric-rendering-v1 3.2.0+6fd945a04f |-- fabric-resource-conditions-api-v1 2.3.14+78d798af4f |-- fabric-resource-loader-v0 0.11.20+df798a894f |-- fabric-screen-api-v1 2.0.17+78d798af4f |-- fabric-screen-handler-api-v1 1.3.55+78d798af4f |-- fabric-sound-api-v1 1.0.17+78d798af4f |-- fabric-transfer-api-v1 4.0.11+eb30349a4f -- fabric-transitive-access-wideners-v1 5.0.14+78d798af4f - fabricloader 0.15.7 -- mixinextras 0.3.5 - faster-random 3.0.3 - fastipping 1.0.1 - ferritecore 6.0.3 - java 17 - krypton 0.2.6 -- com_velocitypowered_velocity-native 3.2.0-SNAPSHOT - ksyxis 1.2.2 - lazy-language-loader 0.3.5 - lazydfu 0.1.3 - lithium 0.12.1 - memoryleakfix 1.1.5 - minecraft 1.20.4 - modelfix 1.14 - noframeratelimit 1.20.2+build.1 - railoptimization 1.0 - smoothscrollingrefurbished 1.1.2 - stutterfix mc1.20.3-0.2.0 - threadtweak 1.20.4-0.1.2 - toomanyplayers 1.20.4-1.1.5 |-- libgui 9.2.2+1.20.2 | |-- jankson 6.0.0+j1.2.3 | | -- blue_endless_jankson 1.2.3 | -- libninepatch 1.2.0 -- midnightlib 1.5.3 - vulkanmod 0.4.0 |-- org_lwjgl_lwjgl-shaderc 3.3.2 |-- org_lwjgl_lwjgl-shaderc_natives-linux 3.3.2 |-- org_lwjgl_lwjgl-shaderc_natives-macos 3.3.2 |-- org_lwjgl_lwjgl-shaderc_natives-macos-arm64 3.3.2 |-- org_lwjgl_lwjgl-shaderc_natives-windows 3.3.2 |-- org_lwjgl_lwjgl-vma 3.3.2 |-- org_lwjgl_lwjgl-vma_natives-linux 3.3.2 |-- org_lwjgl_lwjgl-vma_natives-macos 3.3.2 |-- org_lwjgl_lwjgl-vma_natives-macos-arm64 3.3.2 |-- org_lwjgl_lwjgl-vma_natives-windows 3.3.2 |-- org_lwjgl_lwjgl-vulkan 3.3.2 |-- org_lwjgl_lwjgl-vulkan_natives-macos 3.3.2 -- org_lwjgl_lwjgl-vulkan_natives-macos-arm64 3.3.2"

thasave14 avatar Apr 29 '24 19:04 thasave14

I tried to reproduce it multiple times but could not manage to. Could you try if that happens without any other mod?

xCollateral avatar May 01 '24 16:05 xCollateral

im gonna try

thasave14 avatar May 01 '24 19:05 thasave14

yea hum, i tried and it seems that without every other mod the issue gets fixed

thasave14 avatar May 02 '24 13:05 thasave14

Finding which mods are causing the issue would be helpful.

xCollateral avatar May 04 '24 15:05 xCollateral

im running on java 17 version 1.20.4 and after 20-30 minutes of loading and changing chunks this happens seemingly at random. VulkanMod_1.20.4-0.4.1 Chunks do not render after a certain distance aswell. using /back on the server causes the extreme visibleness of the bug as I replied previously using images.

Was running on a server using KingdomsX plugin and not much else directly related to chunks or rendering, nothing forge related. https://github.com/xCollateral/VulkanMod/assets/91396482/f7f97980-9155-47d8-a8c2-80eacecdfedd

Daxy7 avatar May 04 '24 21:05 Daxy7

exactly the same, if previously i said that without mods it fixed, it was because i didn't run it long enough

thasave14 avatar May 05 '24 18:05 thasave14

and with 0.4.1 it still has the issue

thasave14 avatar May 05 '24 19:05 thasave14

Could you check if the issue still occurs with the latest commit?

xCollateral avatar May 08 '24 15:05 xCollateral

sure, ima do it

thasave14 avatar May 09 '24 12:05 thasave14

@xCollateral Can you send a compiled development build of https://github.com/xCollateral/VulkanMod/commit/85e583d60f73020036ef45b6fea0226a0e0bcfd3 ?

Daxy7 avatar May 09 '24 16:05 Daxy7

@xCollateral Can you send a compiled development build of 85e583d ?

https://github.com/xCollateral/VulkanMod/actions/runs/9004394464

melamit avatar May 09 '24 17:05 melamit

using what melamit suggested to install, the bug in action. seperate case. I did not check if the blocks updating bug was still an issue. It seems to be gone. will edit if occurs in rendering. It is now chests/interactable blocks that dissapear after 20-30 minutes of gameplay. https://github.com/xCollateral/VulkanMod/assets/91396482/ffb343c2-7e89-4a5c-9318-2bc6228e2a58

System specs: https://github.com/xCollateral/VulkanMod/files/15267337/c602a195-f6d6-4e88-91c9-a94c76a6e9f7.txt

Daxy7 avatar May 09 '24 20:05 Daxy7

using what melamit suggested to install, the bug in action. seperate case. I did not check if the blocks updating bug was still an issue. It seems to be gone. will edit if occurs in rendering. It is now chests/interactable blocks that dissapear after 20-30 minutes of gameplay. https://github.com/xCollateral/VulkanMod/assets/91396482/ffb343c2-7e89-4a5c-9318-2bc6228e2a58

System specs: https://github.com/xCollateral/VulkanMod/files/15267337/c602a195-f6d6-4e88-91c9-a94c76a6e9f7.txt

I recommend not to use TLauncher, many reports that it is unsafe to use, don't have any proof but still, be careful with it. I recommend to use ShatteredPrism, you can check it's source code and unlike prismlauncher it supports FTB and Offline auth

melamit avatar May 10 '24 11:05 melamit

i dont have so much freetime lately, can someone that has this issue check for me?

thasave14 avatar May 12 '24 18:05 thasave14

i think it might depend on the device maybe or the mod itself, I just used the Vulkan mod solo and traveled out until after the spawn chunks and the blocks weren't disappearing after being broken or appearing after being placed. And in the video the other guy showed, it was pretty laggy. And my device is also really bad.

Dashy22 avatar May 14 '24 03:05 Dashy22

I can confirm issue on the latest version. For me it's happens on a server and resolves with F3+A.

arturamiryan avatar May 16 '24 18:05 arturamiryan

dad55e7 should have solved this issue. Can someone check if it's still happening or not?

xCollateral avatar Jun 10 '24 14:06 xCollateral

I will check. But it's hard, because I don't know how to reproduce the issue, other than just playing. So, I just download artifact from here? https://github.com/xCollateral/VulkanMod/actions/runs/9419390665

arturamiryan avatar Jun 11 '24 20:06 arturamiryan

Latest version (0.4.3) should have solved this issue.

xCollateral avatar Jun 20 '24 10:06 xCollateral