VulkanMod icon indicating copy to clipboard operation
VulkanMod copied to clipboard

hard fail on incompatible mods

Open ArnaudLier opened this issue 3 years ago • 3 comments

this gives a better explanation to end users when a mod from #46 is loaded than just a crash (also removed the default suggest dependency)

ArnaudLier avatar Sep 18 '22 08:09 ArnaudLier

I usually don't like hard fail on incompatible mods unless strictly necessary, because this prevent the other mods from ever being compatible with VulkanMod.

At this time Fabric don't expose any APIs to allow a mod inside "breaks" to start, so it may ruin indefinitely the change of any of theses mods of working with VulkanMod ever.

Fox2Code avatar Sep 23 '22 10:09 Fox2Code

What about only hardfailing on mods that will never be compatible with VulkanMod like Sodium?

ArnaudLier avatar Sep 23 '22 10:09 ArnaudLier

Yeah I agree for that.

Fox2Code avatar Sep 23 '22 12:09 Fox2Code