xcdat icon indicating copy to clipboard operation
xcdat copied to clipboard

[PR]: Add Z axis support for spatial averaging

Open pochedls opened this issue 1 year ago • 7 comments

Description

This PR adds functionality to compute vertical averages.

  • Closes #596

Checklist

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] My changes generate no new warnings
  • [x] Any dependent changes have been merged and published in downstream modules

If applicable:

  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass with my changes (locally and CI/CD build)
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

pochedls avatar Feb 14 '24 02:02 pochedls

I'd appreciate testing with real-world data (and comparisons with CDAT).

pochedls avatar Feb 14 '24 02:02 pochedls

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (5de4d7f) to head (98ea3d7).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #606   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines         1588      1595    +7     
=========================================
+ Hits          1588      1595    +7     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 14 '24 02:02 codecov[bot]

Tom:

  • [ ] Compare with cdms2 average with Z axis and get floating point diffs
  • [ ] Try out in e3sm_diags

tomvothecoder avatar Feb 14 '24 18:02 tomvothecoder

I'm going to pick this back up for review. We might be able to get this in for v0.7.0.

tomvothecoder avatar Mar 21 '24 17:03 tomvothecoder

I'd appreciate testing with real-world data (and comparisons with CDAT).

Can you provide me some datasets to test with? I wrote a script and tested a single E3SM dataset, which produced nearly identical results (1e-16 max rel diff).

tomvothecoder avatar Mar 21 '24 17:03 tomvothecoder

I'd appreciate testing with real-world data (and comparisons with CDAT).

Can you provide me some datasets to test with? I wrote a script and tested a single E3SM dataset, which produced nearly identical results (1e-16 max rel diff).

Do you have xsearch running? I think you could look for monthly, historical data, for the thetao or ta (Amon table) variables.

pochedls avatar Mar 21 '24 23:03 pochedls

I'd appreciate testing with real-world data (and comparisons with CDAT).

Can you provide me some datasets to test with? I wrote a script and tested a single E3SM dataset, which produced nearly identical results (1e-16 max rel diff).

Do you have xsearch running? I think you could look for monthly, historical data, for the thetao or ta (Amon table) variables.

I'll check on xsearch. Thanks for the pointers.

tomvothecoder avatar Mar 25 '24 16:03 tomvothecoder