J.C. Nelson

Congratulations! I pulled your commits into the main PR in Marlin - they'll be merged when it is!

I think I know what’s happened, I’ll pull each of your commits and let you know. > On Jun 22, 2020, at 2:43 PM, Magnus Pfeffer wrote: > > >...

Ok…try now. I’m pretty much awful with git, but it looks like I got the changes (I hope). > On Jun 22, 2020, at 2:43 PM, Magnus Pfeffer wrote: >...

You should do it if the thermistor type is a thermocouple. There has to be a pattern for this (I’m just not sure what it is). > On Jun 22,...

My recommendation is to do it in thermal manager::Init, something like if sensor1 == -1 (whatever it is) and PIN_EXISTS (THERMISTOR SOMEHTING) set it. > On Jun 22, 2020, at...

I also broke the CI build. I will fix it in a bit. I want to use the conditionals and just add a NOT() Sent from my iPhone > On...

I’m testing a build now (build only, of course, since I”m far from home) that uses this to make sure that the pin is always in the right state (I...

Well, it turns out you change may be the only way it works - conditionals aren’t always defined, so while this looks pretty, it doesn’t work. I’ll revert to your...

Well, I was never one to do something straightforward. Let me ask it again simply, if this is true: Thermistors == pins high Thermocouple == pins low Or is it...

What I expect is that this pin is disabling the path to ground for the divider network (since the thermocouple wouldn’t use it). I’m sorry we’re having to iterate so...