Christos Bisias

Results 60 comments of Christos Bisias

Moved everything back to how it was and added these [two methods](https://github.com/xBis7/ozone/blob/HDDS-7329/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java#L1280-L1302) used only by the CLI. This achieves the wanted behavior and I think it doesn't affect the system...

@kerneltime Let me explain in more details the purpose of this PR. The issue is that you can either have `ip` or `hostname` and use only one of them to...

@sokui @Xushaohong If this [Map](https://github.com/apache/ozone/blob/4c65a07b124b21aa85aa3711035fd8616e13db38/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java#L125) holds both IPs and Hostnames at all times, will this be an issue? In case we are in an ip changing environment and the ip...

@Xushaohong > Kill/ Restart one DN pod could change the IP. This works fine with the current approach. Any particular scenarios or test cases? Commands to execute? I'm referring to...

> Please add a end to end robot test which should help close the loop for the feature. @kerneltime I added the robot test you requested.

@kerneltime After some testing, it seems that making the use of hostname the default option breaks the system except for a kubernetes environment due to pipeline allocation to datanodes. To...

@adoroszlai Please, feel free to take this over. As far as I can recall, these were the unresolved issues that blocked this ticket - We need to use hostnames with...

@adoroszlai Thanks for finishing this. I've gone through the changes. LGTM!

@adoroszlai Thanks for updating the PR and pointing out the test failure. I'll take a look.

We added this file `/hadoop-ozone/integration-test/src/test/resources/META-INF/services/org.apache.hadoop.ozone.om.protocolPB.OmTransportFactory` under `integration-test` which was forcing tests to use Hadoop RPC despite their configurations. The test that was failing, needed to use gRPC and had been...