XbimWebUI icon indicating copy to clipboard operation
XbimWebUI copied to clipboard

Improve depth(for picking) bits precision

Open ictwayman opened this issue 2 years ago • 3 comments

Modifications to obtain accurate values in 3D space (x,y,z) of a specific point on the mesh by clicking the mouse on the polygon mesh. This change is a correction to improve the existing inaccuracies.

I think this change resove the issue below. https://github.com/xBimTeam/XbimWebUI/issues/403

ictwayman avatar Mar 29 '23 02:03 ictwayman

I am not sure I have to target branch master or develop. This PR targets to master branch. please reply for this.

ictwayman avatar Mar 29 '23 05:03 ictwayman

Cheers for this. Will leave to @martin1cerny to review formally as it's his area.

Would be good to understand the approach here, and how standard an approach this is - was 16bits not enough precision?

Have you done much testing have you done on different browsers (webgl1 vs webgl2)?

andyward avatar Mar 29 '23 08:03 andyward

@andyward oh! I just checked my code on webgl with chrome browser with execution parementer. ( --disable-webgl2 )

I think my change is only for the webgl 2 browser. for the webgl1 more research is needed.

please cross check about this PR.

ictwayman avatar Mar 29 '23 10:03 ictwayman