XbimGeometry icon indicating copy to clipboard operation
XbimGeometry copied to clipboard

Possible Bug in ShapeLabel with OpeningsAndAdditionsIncluded

Open RespectableRuessel opened this issue 4 years ago • 1 comments

Hello, at the moment I'm implementing a hierarchy structure in the XbimGLTF converter which converts different shapes into different nodes with a common parent node. However, during the implementation I noticed that the IfcShapeLabel for some XbimShapeInstance in OpeningsAndAdditionsIncluded is exactly the same as the EntityLabel. Actually, the IfcShapeLabel should be different. After taking a closer look at the problem I found that the correct IfcShapeLabel is on the XbimShapeInstance that does not have the OpeningsAndAdditionsIncluded as RepresentationType.

Expected ShapeLabel vs Actual ShapeLabel

I logged every label from the XbimShapeInstance and here is a common case where the wall has some boolean operation because it contains voids for windows:

New Enity: Basic Wall:Exterior - Brick on Block:143534
shapeInstance.IfcProductLabel: 114
shapeInstance.InstanceLabel: 92
shapeInstance.ShapeGeometryLabel: 309
shapeGeometry.IfcShapeLabel: 114
shapeGeometry.ShapeLabel: 309

Here the IfcProductLabel matches the IfcShapeLabel which I think is actually wrong. The correct IfcShapeLabel should be the same as in the XbimShapeInstance that does not match OpeningsAndAdditionsIncluded:

New Enity: Basic Wall:Exterior - Brick on Block:143534
shapeInstance.IfcProductLabel: 114
shapeInstance.InstanceLabel: 38
shapeInstance.ShapeGeometryLabel: 124
shapeGeometry.IfcShapeLabel: 5754
shapeGeometry.ShapeLabel: 124

Here the number 5754 is right.

Assemblies and versions affected:

XBimGeometry 5.1.402-develop

RespectableRuessel avatar Feb 26 '21 11:02 RespectableRuessel

Hi, I found the same problem. Do you solve this?

Bright-Brave avatar Jun 02 '22 07:06 Bright-Brave