Course module completion state sent as complete, even if not complete

[ericmerrill]

Description

• Every time the event course_module_completion_updated fires, logstore_xapi assumes that it means the activity has been completed. But that isn't always the case. In vanilla Moodle it can also happen if a completion is overridden by the instructor to the not complete state, and Moodle Workplace can do it during user progress resets.

Version

• Version 2022101800 from master

Steps to reproduce the bug

1. A a teacher, in the Activity Completion report
2. Override a user activity to the complete state, if none are already in that state.
3. Now override the activity to the incomplete state

Expected behaviour

• The override to incomplete state should either emit a statement saying the event not complete, or if that isn't an option (I don't know the available statements), shouldn't emit anything.

Actual behaviour

• Emits a statement saying the activity is complete, regarless of the actual completion state.