Refactor constant names to follow Moodle frankenstyle coding standard

[Undreli-Studios]

Good day team, there are a few places that could need a bit of a refactor to comply with Moodle coding style standard.

Description

In the file 'lib.php' which you can see here https://github.com/xAPI-vle/moodle-logstore_xapi/blob/master/lib.php, contains a few constants with names that do not comply with Moodle coding standard. In particular they lack the Frankenstyle with the plugin name that you can check here: https://docs.moodle.org/dev/Coding_style#Constants, for example:

define('XAPI_IMPORT_TYPE_HISTORIC', 1);
define('XAPI_IMPORT_TYPE_FAILED', 2);

This should be:

define('LOGSTORE_XAPI_IMPORT_TYPE_HISTORIC', 1);
define('LOGSTORE_XAPI_IMPORT_TYPE_FAILED', 2);

Version

• master at 416b92cfd672e02e1c92b5 2022101800

Expected behaviour

• The constants defined by this plugin should follow the Frankenstyle coding style from Moodle.

Actual behaviour

• The constants do not follow this standard.

Thank you so much for you attention.

[davidpesce]

Thanks for the heads up on this! Feel free to submit a PR if you have some time.