libltc icon indicating copy to clipboard operation
libltc copied to clipboard

const correctness

Open superbigio opened this issue 6 years ago • 3 comments

Would you be interested in making libltc const-correct? I think it's a pretty simple API so it shouldn't be too difficult to do. I think about a dozen of functions would be affected.

I may have a PR ready for this. Let me know...

superbigio avatar Nov 09 '19 00:11 superbigio

That'll likely break API and ABI, won't it?

x42 avatar Nov 09 '19 01:11 x42

Yes, adding const as a parameter qualifier will break ABI compatibility, but not API. The API will still be able to compile and work, however there may be a few compiler warnings being thrown at you. (harmless but a little annoying) Although this also depends upon your compiler settings. If you give me permission to send you a PR I will do my best to get rid of all kinds of warnings and annoyances that such a change may produce. However the ABI will break regardless.

superbigio avatar Nov 09 '19 12:11 superbigio

Also interested by that

lp35 avatar Mar 31 '20 14:03 lp35