simpleauth
simpleauth copied to clipboard
x1ddos
use ndb
what does this pull request achieve, and why should it be merged?
use ndb
doesn't really explain much at all? no comments in the source either
Sorry.
The NDB is new feature that can write without blocking code in Google App Engine / Python 2.7. https://developers.google.com/appengine/docs/python/ndb/async
Now, simpleauth is blocking in old urlfetch.fetch method. It is a performance concerns.
This can be done without NDB, which might be a good idea since there could be some folks not yet using the 2.7 runtime or NDB (for whatever reason).
i am using ndb in my project , but I didn't realize it had this async functionality.
On 23 Dec 2013, at 12:01 pm, Eric Higgins [email protected] wrote:
This can be done without NDBhttps://developers.google.com/appengine/docs/python/urlfetch/asynchronousrequests, which might be a good idea since there could be some folks not yet using the 2.7 runtime or NDB (for whatever reason).
— Reply to this email directly or view it on GitHubhttps://github.com/crhym3/simpleauth/pull/27#issuecomment-31100341 .
@MiCHiLU I have some doubts as to whether this PR really enhances anything:
_oauth2_callback is the first to be called (unless you're doing something in a middleware), which then invokes _on_signin. You'll need auth/profile data in _on_signin anyway, so you'll have to wait before doing anything else.
Am I missing something?
