Sentry icon indicating copy to clipboard operation
Sentry copied to clipboard

Separate button for selecting and deselecting the reset.

Open Markus40 opened this issue 2 years ago • 5 comments

It is possible to prevent the app from resetting the phone if the maximum number of attempts is set to 0, but this is not described anywhere and not intuitive. It also prevents you from wiping the phone on one wrong attempt.

I think it would be better to have a separate button that selects the reset.

Markus40 avatar Sep 25 '22 15:09 Markus40

It also prevents you from wiping the phone on one wrong attempt.

What is the problem to set it to 1?

x13a avatar Sep 25 '22 21:09 x13a

If setting it to 1 wipes the phone on the first wrong password, the description is misleading. As I understand it, "maximum number of" includes the number. If there is a sign that says "Maximum number of apples you can take is 10", you are not stealing when you take 10 apples.

The description should be something like: "Number of wrong attempts at which point the phone gets wiped"

Markus40 avatar Sep 25 '22 22:09 Markus40

OK, I will rename it to the same as API setMaximumFailedPasswordsForWipe -> Maximum failed password attempts for wipe.

https://developer.android.com/reference/android/app/admin/DevicePolicyManager#setMaximumFailedPasswordsForWipe(android.content.ComponentName,%20int)

x13a avatar Sep 25 '22 22:09 x13a

The wording of the API is strange because the number of attempts should be the minimum or exact number required to trigger a wipe, not the maximum.

The changed wording is better and understandable, but I would just remove "Maximum" and call it: "Failed password attempts for wipe" if you want to stay closer to the official wording.

Markus40 avatar Sep 25 '22 22:09 Markus40

I will think of it.

x13a avatar Sep 25 '22 22:09 x13a