rcx icon indicating copy to clipboard operation
rcx copied to clipboard

Sorting order resetting

Open ctlaltdefeat opened this issue 3 years ago • 6 comments

What version of RCX are you using (About -> App version)?

1.12.1

What is your Android version, phone model and manufacturer?

Android 11, OP8 Pro

Which steps are required to reproduce this issue?

Sort a (remote/local) directory, enter a subdirectory, go back. The directory is now not sorted by the order selected previously, despite the same options still being selected in the sorting menu. I don't know if "bug" is the correct term for this, or if persisting the sorting order is just not intended to be a feature yet.

ctlaltdefeat avatar Jul 07 '21 17:07 ctlaltdefeat

In general, there is a single, global sort setting. After someone selects "OK" in the sort dialog, the chosen sort order is applied and saved. When navigating back, this sort order is applied as well.

I'm really not sure what is happening on your device; it works as described for me. There is some potential for a timing bug though. The new sort order is only saved after sorting the current folder. If someone where to navigate back while the current folder is still being sorted, the new sort order would probably not be used.

What happens when you refresh the parent directory? Which sort order do you observe then?

x0b avatar Jul 09 '21 13:07 x0b

When I refresh the parent directory, the incorrect default sort order remains. Only when I go into the sort menu and press OK do I get the correct selected order.

ctlaltdefeat avatar Jul 11 '21 20:07 ctlaltdefeat

That is really weird. So the order is this:

  1. You are in a folder.
  2. You open the sort Dialog and select a different sorting option.
  3. You close the sort dialog with OK
  4. The folder starts refreshing
  5. You navigate back to the parent folder - before or after the sorting has finished?
  6. The parent folder is still following the old sorting order
  7. You open the sort Dialog again and the same selection as in Step 2 is still selected
  8. You select OK again and now the parent is correctly sorted

Is that correct? Sorry if I'm asking so many questions, I've just so far not managed to cause the same bug on my devices. Would it maybe possible to send in a video that shows the bug?

x0b avatar Jul 17 '21 10:07 x0b

https://files.catbox.moe/7j2xsf.mp4

ctlaltdefeat avatar Jul 17 '21 13:07 ctlaltdefeat

Thanks for the video. Something is clearly going wrong. I'll investigate.

x0b avatar Jul 18 '21 10:07 x0b

Figured it out. For some reason, the sort order is inverted for size and mod time. The bug has been there since before my time with RCX, I'm really surprised we only discovered this now.

x0b avatar Jul 18 '21 20:07 x0b