wz1000

Results 148 comments of wz1000

Optimization: cache semantic lookup in tokenizer, add semantic tokens bench marks

could we have some benchmarks on large files to see if this actually makes a difference?

Optimization: cache semantic lookup in tokenizer, add semantic tokens bench marks

Looks like a decent improvement. Could you add this benchmark to the ghcide-bench experiments please?

Optimization: cache semantic lookup in tokenizer, add semantic tokens bench marks

the `ghcRebuilds` number seems to indicate that we aren't editing the file in the benchmark passes. Could you ensure that each benchmark iteration also edits the file?

HLS stuck (init then no progress) since multi home support

I would add more traces in Session.hs to figure out exactly where it gets stuck.

HLS stuck (init then no progress) since multi home support

Yeah this might be a GHC bug. Can you print out `(hsc_unit_env hscEnv')` and `(hsc_all_home_unit_ids hscEnv')` please?

HLS stuck (init then no progress) since multi home support

Also printing out the `closure_errs` might be enlightening. It seems likely that the home units are not closed for your project. This means that there are "home units"(units that you've...

HLS stuck (init then no progress) since multi home support

> hsc_unit_env is an UnitEnv which does not have Show you want to use `pprUnitEnvGraph` from GHC.

HLS stuck (init then no progress) since multi home support

Thanks @carbolymer, thanks to your reproducer I was able to diagnose the issue and put up a fix in #4109

session-loader: Don't loop forever when we don't find a file in any multi component

> Is this related to #4046 ? I don't think so

Fix hls-graph: phantom dependencies invoke in branching deps (resolve #3423)

I don't think we need to complicate the API by introducing side conditions - we just need to try evaluating dependencies in order. This means instead of maintaining a `KeySet`...