stripe-rs icon indicating copy to clipboard operation
stripe-rs copied to clipboard

Integrated generated code for /v1/account_links

Open scrblue opened this issue 3 years ago • 4 comments

Simply includes the generated code and adds the mod and pub use statements in resources.rs. One modification from the generated code was made for API compliance: the generated AccountLinkType enum had the options CustomAccountUpdate and CustomAccountVerification, but I changed it to AccountUpdate and AccountOnboarding to match the API documented here. The resulting functionality was tested a decent amount and seems to work properly.

scrblue avatar Oct 16 '20 00:10 scrblue

Hello, apologies for the late reply. We are working on getting up to speed on pull requests. May I ask if you are still interested in merging this (we are!) that you rebase? Thank you.

As a general rule we should probably refrain from hand-editing the generated code, even though it deviates slightly from the spec, and instead look to change the codegen.

arlyon avatar Apr 20 '21 16:04 arlyon

Hi, I can definitely get it working with the current master branch sometime soon. I'll take a look at the generation first too :)

scrblue avatar Apr 20 '21 20:04 scrblue

Happy to give pointers if needed.

arlyon avatar Apr 21 '21 13:04 arlyon

What are the issues in the codegen that are causing the generated field names to be incorrect? Is it using an old schema of the API for generation?

seanpianka avatar Sep 11 '21 21:09 seanpianka