lsp-editor-adapter icon indicating copy to clipboard operation
lsp-editor-adapter copied to clipboard

LspWsConnection does not implement on, off.

Open krassowski opened this issue 4 years ago • 2 comments

First off, thanks for devolving this adapter, it's very useful!

I am getting following error when trying to set-up the example from README:

Type "LspWsConnection" is not assignable to parameter of type "ILspConnction"
Type "LspWsConnection" is missing following properties from type "ILspConnction": on, off

I can @ts-ignore it, but after looking through the sources it seems that the on & off implementation is indeed missing - or am I missing something?

krassowski avatar Jul 19 '19 13:07 krassowski

Okey, it has to be something on my part/versions incompatibility. I've just realized that it is probably hidden within the EventEmitter.

krassowski avatar Jul 19 '19 13:07 krassowski

Solved by:

npm install events
npm install @types/events

Should events and types for events be included in the package.json's dependencies / devDependencies?

krassowski avatar Aug 16 '19 18:08 krassowski