wyattscarpenter
wyattscarpenter
@github-actions https://github.com/awslabs/sockeye/blob/e42fbb30be9bca1f5073f092b687966636370092/sockeye/layers.py#L642 ```py projected_memory_kv: Optional[pt.Tensor] = None) -> pt.Tensor: # mypy: ignore ``` Incredible... looks like this PR already has a consumer :) The demand of the people for this...
Well... that's not good.
We do a lil "finding out there are bugs in `tokenize`". https://github.com/python/cpython/issues/125008
We do a lil "finding out there are bugs in 3.8 `tokenize`" https://bugs.python.org/issue35107
I plan to just include a more recent copy of tokenize here; note to self that I will have to mention this in the copyright file (along with the several...
Looks like 3 weeks ago they [dropped support for 3.8](https://github.com/python/mypy/pull/17492), as was under discussion last time I was thinking about this project. I've successfully procrastinated my way out of another...
Well, that mypy_primer diff seems, I dunno, fine. Time to finalize this adventure.
@JukkaL That's a very reasonable concern. I myself anticipated there might be some performance hit, and was surprised when mypy primer (and also my first-hand experience) noticed no performance degradation....
I haven't subsequently thought of a way to implement this technique without a slowdown (although I haven't been looking very hard), so I guess I'll just close this PR, and...
You have a large number of test failures here, presumably because a bunch of expected errors have switched to giving the pretty error messages now! These will need to be...