Tim Pillinger

Results 218 comments of Tim Pillinger

So I think that in the end my decision (with Oliver's approval) was as follows: - Master after https://github.com/cylc/cylc-flow/pull/5721 and 8.2.x have now diverged significantly. - Almost no-one is using...

> ``` > tests/integration/tui/test_updater.py::test_filters - TypeError: 'NoneType' object is not subscriptable > ``` > > Looks genuine? Yes, it was both genuine and potentially nasty. Hopefully ok now, although it...

> However `foo` fails again `fail try 1 only` != `fail submit 1 only`: It only plays with `execution retry delays`, not manual resubmits. I'm not sure if that's OK,...

> That's OK, but the docs could do with that detail > > ![image](https://private-user-images.githubusercontent.com/61982285/304382023-da36359a-5262-4a36-9ba1-7b64c5bb15b6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDc4MjIzNDUsIm5iZiI6MTcwNzgyMjA0NSwicGF0aCI6Ii82MTk4MjI4NS8zMDQzODIwMjMtZGEzNjM1OWEtNTI2Mi00YTM2LTliYTEtN2I2NGM1YmIxNWI2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAyMTMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMjEzVDExMDA0NVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTY2MjRhNWI1ODI4NDMxNmE3N2ZmNjRhOThmMmQ2NWM5OWQ4M2I2ZjQ2NmI4ZGYzOWIyZWFlMWE3Nzg1OTU3ZTUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.3bav-nyl46DOzuYPGX0P2yoWN3IBWm5ArdZYStore_k) Agreed - see the commit immediately above this comment. 😄 (https://github.com/cylc/cylc-flow/pull/5721/commits/e9a087e77eca37b46573cbb6d4cdf7f25fd8ced0)

> Are the mode_settings are being created when the task is created (which would be immediately after 1/a submits in this case) rather than when the task is submitted (which...

> ``` > > ``` > > > > > > I tried setting `fail try 1 only=True` after `foo` had already retried a few times and got this Think...

> Broadcasting `[simulation]default run length=PT1S` causes the task to succeed 😕 Got it - side effect of earlier change.

> * Broadcasting `execution retry delays` does not cause a change when running in simulation mode I cannot replicate this on the command line. Given the context of your comment...

@MetRonnie - This is a good spot. I think that the broadcasts probably need to be applied in the `TaskJobManager._simulation_submit_task_jobs` method to ensure that we are broadcasting all task settings,...