Tim Pillinger

Results 218 comments of Tim Pillinger

> This may be solved with #471 if it's suitable to present these controls in the view toolbar. Seems legit

IMO this ought to be available as a fixture out of the box since I seem to be using it a lot, and this feels like code to be re-used.

5 minutes of playing with it makes me favour prettier. Prettier's front page makes it look like Black, which I'd be wary of, but it looks a good deal more...

Let us know when you want us to have a review at this.

Probably worth getting the Pygraph issue fixed too?

I've opened #2784 - it looks like the bug I found is unrelated to this work.

> Small problem, although this test works as expected locally, the CI tests have passed _before_ the upstream PRs were merged. > > Presumably these tests are skipped in CI?...

> I don't think that's right, `fcm_make` must load the workflow config in order to check whether there is a corresponding `fcm_make2` task. If `fcm_make2` is present, we would probably...

> Upstream PRs are in, so I would expect the tests to pass, but they have failed again, @wxtim could you take a look. > I don't think that's right,...

I've changed this test: It now checks that the error logged by the `fcm_make` task refers to the platform (for `fcm_make2`) being garbage. Without the fix you instead get an...