fix: recreating keyboardShortcuts interface on file changes.

[nishu-murmu]

Overview

I noticed that keyboard shortcuts weren't working after files were being saved or HMR was triggered. Hope this fixes it.

[netlify[bot]]

✅ Deploy Preview for creative-fairy-df92c4 ready!

Name	Link
🔨 Latest commit	abc7f153f0a0dfcbc094debef11df7cd25bc253d
🔍 Latest deploy log	https://app.netlify.com/projects/creative-fairy-df92c4/deploys/68412b29909b4200089167a5
😎 Deploy Preview	https://deploy-preview-1465--creative-fairy-df92c4.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[nishu-murmu]

Was noticing this too but wouldn't this potentially be a memory leak since we keep creating it?

Yeah, now that I think about it, it really can be. as such there are already existing issues for windows. We can just close the listeners instead of the interface. That way only one interface will be used.

[pkg-pr-new[bot]]

Open in StackBlitz

@wxt-dev/analytics

npm i https://pkg.pr.new/@wxt-dev/analytics@1465

@wxt-dev/auto-icons

npm i https://pkg.pr.new/@wxt-dev/auto-icons@1465

@wxt-dev/browser

npm i https://pkg.pr.new/@wxt-dev/browser@1465

@wxt-dev/i18n

npm i https://pkg.pr.new/@wxt-dev/i18n@1465

@wxt-dev/module-react

npm i https://pkg.pr.new/@wxt-dev/module-react@1465

@wxt-dev/module-solid

npm i https://pkg.pr.new/@wxt-dev/module-solid@1465

@wxt-dev/module-svelte

npm i https://pkg.pr.new/@wxt-dev/module-svelte@1465

@wxt-dev/module-vue

npm i https://pkg.pr.new/@wxt-dev/module-vue@1465

@wxt-dev/runner

npm i https://pkg.pr.new/@wxt-dev/runner@1465

@wxt-dev/storage

npm i https://pkg.pr.new/@wxt-dev/storage@1465

@wxt-dev/unocss

npm i https://pkg.pr.new/@wxt-dev/unocss@1465

@wxt-dev/webextension-polyfill

npm i https://pkg.pr.new/@wxt-dev/webextension-polyfill@1465

wxt

npm i https://pkg.pr.new/wxt@1465

commit: abc7f15

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.90%. Comparing base (240bbb3) to head (abc7f15). Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
packages/wxt/src/core/create-server.ts	50.00%	2 Missing :warning:
packages/wxt/src/core/keyboard-shortcuts.ts	50.00%	1 Missing :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1465      +/-   ##
==========================================
- Coverage   81.27%   80.90%   -0.37%     
==========================================
  Files         130      130              
  Lines        6642     6642              
  Branches     1087     1086       -1     
==========================================
- Hits         5398     5374      -24     
- Misses       1233     1257      +24     
  Partials       11       11              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:

• :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions[bot]]

Thanks for helping make WXT better!

[PendalF89]

Hi guys, after upgrading from 0.20.7 => 0.20.8 I encountered with this warnings in console:

✔ Opened browser in 618 ms                                                                                                                  16:37:31
ℹ Press o + enter to reopen the browser                                                                                                     16:37:31
(node:1604) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 line listeners added to [Interface]. MaxListeners is 10. Use emitter.setMaxListeners() to increase limit
    at genericNodeError (node:internal/errors:985:15)
    at wrappedFn (node:internal/errors:539:14)
    at _addListener (node:events:581:17)
    at Interface.addListener (node:events:599:10)
    at Object.start (file:///C:/Users/Boris/WebstormProjects/test/node_modules/wxt/dist/core/keyboard-shortcuts.mjs:18:10)
    at FSWatcher.<anonymous> (file:///C:/Users/Boris/WebstormProjects/test/node_modules/wxt/dist/core/create-server.mjs:78:27)

I think, it's related with this issue.