Phoenix icon indicating copy to clipboard operation
Phoenix copied to clipboard

Refactored customtreecontrol and hypertreelist from PR#2088

Open HelioGuilherme66 opened this issue 8 months ago • 4 comments

This is the updated files from https://github.com/cbeytas/Phoenix

Fixes PR#2088

Note: This need careful review!

HelioGuilherme66 avatar Apr 17 '25 17:04 HelioGuilherme66

This pull request has been mentioned on Discuss wxPython. There might be relevant details there:

https://discuss.wxpython.org/t/customtreecontrol-escaping-edit-node-label-causes-inconsistent-state-on-linux/40200/6

RobinD42 avatar Apr 17 '25 17:04 RobinD42

Is it possible to untangle the formatting changes to make it reviewable? Either a separate commit if absolutely needed, or a different PR. I tried taking a look, GitHub's mobile UI doesn't want to load it. And scrolled a bit and didn't get to a real change yet

echoix avatar Apr 17 '25 17:04 echoix

Is it possible to untangle the formatting changes to make it reviewable? Either a separate commit if absolutely needed, or a different PR. I tried taking a look, GitHub's mobile UI doesn't want to load it. And scrolled a bit and didn't get to a real change yet

Agreed. That's one of the main reasons I haven't gotten through reviewing the original PR - a massive change, with formatting changes mixed in with functional changes...

swt2c avatar Apr 17 '25 18:04 swt2c

If there's also other improvements that aren't related to the fix needed for your issue, and the changes can live without, it might be a good idea to not include them here too.

These are mitigation ways to help out have a PR reviewed, especially since it was stalled for years because of the difficulty of reviewing it.

echoix avatar Apr 17 '25 18:04 echoix

Closing this as I merged the original PR #2088.

swt2c avatar Aug 05 '25 00:08 swt2c