Phoenix icon indicating copy to clipboard operation
Phoenix copied to clipboard

listctrl TextEditMixin

Open komoto48g opened this issue 3 years ago • 0 comments

Fixes #2271

This PR includes two commits that fix the two issues mentioned in #2271 One is simple. Fixed /4 --> //4 to avoid TypeError. The other one is simple too. Removed TE_RICH2 style to avoid selection disappearing on a second focus. But I suspect that someone dislikes removing the style.

I found that there is another way to fix this issue as follows: https://github.com/wxWidgets/Phoenix/blob/7c4d21d7786c15cd5afeb3b931a035e73b40e514/wx/lib/mixins/listctrl.py#L575-L576

@@ -575,2 +575,2 @@ class TextEditMixin:
-        if self.GetColumn(col).Align != self.col_style:
-            self.make_editor(self.GetColumn(col).Align)
+        # Make new editor even not if self.GetColumn(col).Align != self.col_style:
+        self.make_editor(self.GetColumn(col).Align)

What do you think?

komoto48g avatar Sep 11 '22 04:09 komoto48g