Phoenix icon indicating copy to clipboard operation
Phoenix copied to clipboard

Enable configuration of whether popup dialog should align center, right or left

Open jmoraleda opened this issue 3 years ago • 1 comments

This PR enables configuring horizontal alignment of the popup dialog with respect to the parent control in the python-only popup control.

The default now is center, which was the previous behavior, so this PR does not impact existing code.

However there are cases when one may prefer right or left alignment. In particular right alignment makes sense when the control is wide and the pop up is narrow, so the pop up appears below the expand button.

jmoraleda avatar Aug 06 '22 20:08 jmoraleda

Sorry for the dirty history. The second force-push was a mistake and the third one undoes it. Thus the last two "comparisons" showing lots of changed files are not useful. The first one, or the single commit, are the only one meaningful comparisons. This PR is very straight forward, modifying only a few lines in a single file.

jmoraleda avatar Aug 31 '22 18:08 jmoraleda

Could someone please review this PR? It is only a handful of lines in a single file and I believe it is a useful feature. Thank you.

jmoraleda avatar Dec 09 '22 05:12 jmoraleda