dis-gui icon indicating copy to clipboard operation
dis-gui copied to clipboard

warning " > [email protected]" has incorrect peer dependency "react@^15.3.0".

Open Aarbel opened this issue 6 years ago • 3 comments

Could you upgrade to React 16 ? :)

Aarbel avatar Feb 09 '19 15:02 Aarbel

@wwwtyro @loopmode

Aarbel avatar Feb 09 '19 16:02 Aarbel

Hm. I'm not quite sure, doing that without a major version bump would cause the same kind of warning for all legacy projects that use dis-gui - in my case a couple - and they would complain to please upgrade react 16, which is of course not that easy in a grown/legacy project without upgrading a bunch of other react-* libraries, which in turn might have undergone breaking changes etc.

I think it's not worth it right now without any other changes or improvements, and that bumping to v3.0.0 for just the react 16 change is also not worth it.

I think that, ideally, one would spend some quality time with the codebase, tackle https://github.com/wwwtyro/dis-gui/issues/5 and https://github.com/wwwtyro/dis-gui/issues/9, then both bump the react dependency version to 16 and the dis-gui version to 3.0.0.

@wwwtyro What's your opinion on this?

@Aarbel I guess you know that it's just a warning and nothing serious, thus the smiley in your initial request.. I hope you're not too disappointed with my response and you understand the reasoning behind it?

Actually, I will have some time in the second half of February and I might use it to tackle all of this, but I can't promise..

loopmode avatar Feb 11 '19 08:02 loopmode

@loopmode, i agree it's not a major maintenance issue. Right now dis-gui is working in a React 16 environment without throwing errors.

Thanks a lot for your work !

Aarbel avatar Feb 11 '19 11:02 Aarbel