react-js-pagination icon indicating copy to clipboard operation
react-js-pagination copied to clipboard

Multiple React Instances

Open firzok opened this issue 4 years ago • 4 comments

I think that React and React Dom should be in Peer Dependencies rather than Dependencies in package.json Because of this, npm ls react shows multiple instances of react when react-js-pagination is being used.

P.S: This is my first issue so please bear with me.

firzok avatar Mar 04 '20 06:03 firzok

I'm not sure but several React instances may cause troubles with react hooks

iron66 avatar Mar 17 '20 08:03 iron66

I'm not sure but several React instances may cause troubles with react hooks

Are you saying that the solution I suggested will cause this problem ?

firzok avatar Mar 19 '20 06:03 firzok

@firzok It's the current situation that may cause problems with react-hooks. Your suggestion is helpful and should be addressed imho. See https://reactjs.org/warnings/invalid-hook-call-warning.html

pnicolli avatar May 06 '20 15:05 pnicolli

npm ls react [email protected] C:\Users\PC\Desktop\xxx\client +-- [email protected] -- [email protected] -- [email protected]

https://reactjs.org/warnings/invalid-hook-call-warning.html#duplicate-react

HauresBogdan avatar Oct 26 '20 18:10 HauresBogdan