Buttons with icons and text have extra right-hand padding

[edwloef]

EasyEffects Version

8.0.3

What package are you using?

Arch (easyeffects)

Distribution

Arch Linux

Describe the bug

Pretty much every icon+text button of this style has wonky padding, they look a bit left-of-center. There's way more space between the end of the text and the right border of the button, vs the start of the icon and the left border of the button. This seems to not affect buttons of that style that only have an icon, without text.

Examples:

Expected Behavior

No response

Debug Log

Debug Log

Paste your log here

Additional Information

No response

[wwmm]

Which theme is this one you are using? At least with Breeze they seem very different from the ones you have

[edwloef]

I don't have Breeze installed, so the default for Qt I think?

[wwmm]

I don't have Breeze installed, so the default for Qt I think?

I am not sure about it. Maybe the one called Fusion. In any case I am not sure if this has to be fixed in the theme, Qt/QML or Kirigami. What do you think @CarlSchwan ?

Fixing that weird right padding on our side is probably not the proper way. We may fix one theme and break others.

[wwmm]

Or maybe the solution is installing Breeze if you do not mind its looks.

[edwloef]

Maybe the one called Fusion.

From a quick google that looks correct to me. Apologies, I wasn't aware that Qt had multiple built-in theming options 😆

[vchernin]

Would it make sense for Easy Effects to try to use breeze by default in more cases? As far as I understand with the kirigami package installed the breeze theme is definitely there, it just sometimes isn't being used.

From all the discussions on theming that I've seen the last week, it seems the options should boil down to:

1. Use kirigami + breeze as provided by KDE by default, which has built in support for dark mode and accent color customization.
2. Using qt6ct, kvantum, or custom themes like Fusion with explicit opt in from the user. How exactly that should be implemented I'm not sure, but it seems possible. Maybe a preferences option that is required to start using non breeze themes? Or is that too harsh?

It just seems there is a lot of possible ways to theme or to not theme, which is a recipe for confusion. It is ok if users want to customize but this situation does not seem much better than gtk and libadwaita theming. At the very least the defaults for new users should be less broken.

[wwmm]

1. Use kirigami + breeze as provided by KDE by default, which has built in support for dark mode and accent color customization.

As Kirigami tutorial does that we already have this https://github.com/wwmm/easyeffects/blob/31697a5c3d75ff4abd0b2f6c86354a75d2e3244f/src/main.cpp#L329

Using qt6ct, kvantum, or custom themes like Fusion with explicit opt in from the user.

Setting Breeze as above seems to be what breaks qt6ct

Maybe a preferences option that is required to start using non breeze themes? Or is that too harsh?

I do not see a problem as long as it is something that does not collide with Kirigami behavior.

[vchernin]

1. Use kirigami + breeze as provided by KDE by default, which has built in support for dark mode and accent color customization.

As Kirigami tutorial does that we already have this https://github.com/wwmm/easyeffects/blob/31697a5c3d75ff4abd0b2f6c86354a75d2e3244f/src/main.cpp#L329

Which I find puzzling because how did this bug occur then? Is it actually possible to install the kirigami package which Easyeffects depends on without the breeze theme? Is the breeze theme not integral to kirigami?

Using qt6ct, kvantum, or custom themes like Fusion with explicit opt in from the user.

Setting Breeze as above seems to be what breaks qt6ct

Maybe a preferences option that is required to start using non breeze themes? Or is that too harsh?

I do not see a problem as long as it is something that does not collide with Kirigami behavior.

It may be the best option, it is a bit of a hack to add a new preferences option but qt6ct seems fairly hacky to begin with.

[wwmm]

Which I find puzzling because how did this bug occur then? Is it actually possible to install the kirigami package which Easyeffects depends on without the breeze theme? Is the breeze theme not integral to kirigami?

At least on Arch Linux Breeze is the one that has Kirigami as dependency. Kirigami dependencies are gcc-libs glibc qt6-base qt6-declarative qt6-svg.

[vchernin]

Which I find puzzling because how did this bug occur then? Is it actually possible to install the kirigami package which Easyeffects depends on without the breeze theme? Is the breeze theme not integral to kirigami?

At least on Arch Linux Breeze is the one that has Kirigami as dependency. Kirigami dependencies are gcc-libs glibc qt6-base qt6-declarative qt6-svg.

I don't know what we ought to do here, so I asked in the Kirigami matrix channel #kirigami:kde.org.

[vchernin]

I don't know what we ought to do here, so I asked in the Kirigami matrix channel #kirigami:kde.org.

Apparently the breeze theme is the only theme Kirigami is regularly tested with, so the only real way to avoid these issues is to always install the breeze package. Opened https://github.com/wwmm/easyeffects/pull/4465.

@edwloef was there any particular reason why you did not have the breeze package installed? Could you try installing it and confirm it fixes the issue?

[edwloef]

was there any particular reason why you did not have the breeze package installed?

Just the fact that it wasn't specified as a dependency. Installing breeze does indeed fix this issue.