DeepFilterNet: restrictive value ranges & impossible recommended values

[Hamunii]

The EasyEffects documentation recommends impossible values for 2 fields for DeepFilterNet configuration:

Minimum Processing Threshold: https://github.com/wwmm/easyeffects/blob/c09b677faa9c9680e2365afb74e7fe068ccffe19/src/contents/help/deepfilternet.html#L78-L80

(I'd assume this is where the range is defined) https://github.com/wwmm/easyeffects/blob/c09b677faa9c9680e2365afb74e7fe068ccffe19/src/contents/kcfg/easyeffects_db_deepfilternet.kcfg#L28-L32

Post Filter Beta: https://github.com/wwmm/easyeffects/blob/c09b677faa9c9680e2365afb74e7fe068ccffe19/src/contents/help/deepfilternet.html#L164-L165

https://github.com/wwmm/easyeffects/blob/c09b677faa9c9680e2365afb74e7fe068ccffe19/src/contents/kcfg/easyeffects_db_deepfilternet.kcfg#L48-L52

I have tried looking for a reason as to why, especially as both the ranges and documentation (docs seem to have been originally added here https://github.com/wwmm/easyeffects/commit/61fb40a50afd4fa8ef32f9c8ff0ef3f24cdc6eee) was committed by @wwmm so there must be a technical reason for this restriction? If yes, I'd like to know what it is, and if not, then it'd probably be nice to update these ranges to allow the recommended values.

[wwmm]

I think that it is probably a mistake in the manual text. As far as I can see our current parameter range is the same we had in the gtk4 code.

[wwmm]

then it'd probably be nice to update these ranges to allow the recommended values.

Assuming the plugin actually accepts the range suggest in the manual. We would have to verify this. It is not a plugin a regularly use so I am not sure.

[Digitalone1]

These should be the configuration: https://github.com/Rikorose/DeepFilterNet/blob/main/ladspa/src/lib.rs#L31-L48

The parameters seem the same we use.

[Hamunii]

Oh I see, thanks! Should the recommended values just be removed for those 2 options then? Though, every config option currently has a recommended value. I'd like to offer to fix it myself, but I don't know how exactly it should be fixed.

[Digitalone1]

Oh I see, thanks! Should the recommended values just be removed for those 2 options then? Though, every config option currently has a recommended value. I'd like to offer to fix it myself, but I don't know how exactly it should be fixed.

Here you can set the defauts: https://github.com/wwmm/easyeffects/blob/master/src/contents/kcfg/easyeffects_db_deepfilternet.kcfg

[Hamunii]

Here you can set the defauts: master/src/contents/kcfg/easyeffects_db_deepfilternet.kcfg

Sorry, but do you mean that the (new) recommended values in the docs should be the ones that are the default values?

[Digitalone1]

Sorry, but do you mean that the (new) recommended values in the docs should be the ones that are the default values?

No, if the source code defaults are different than ours, you can change them for Easy Effects.

[wwmm]

As far as I could understand the manual is the one that needs to be fixed.

[hayama77]

Previously, there was no manual for DFN, so I was the first to write it up. At that time, I also added recommended values.

Needless to say, the appropriate recommended values ​​will vary depending on the environment (noise conditions) in which they are used. Currently, the recommended values ​​are written in the source code of DFN, and I believe this is also followed in EasyEffects. As a result, there is a discrepancy between the two.

My suggestion is to remove the recommended values ​​from the manual (as wwmm has said).